public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Aaron Williams <Aaron.Williams@caviumnetworks.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cfi_flash driver: fixed addressing for 8-bit flash buses.
Date: Sat, 30 Apr 2011 12:14:49 -0700	[thread overview]
Message-ID: <4DBC5FA9.8030607@caviumnetworks.com> (raw)
In-Reply-To: <20110430191210.66325D5270F@gemini.denx.de>

Will do. I've been quite busy lately bringing up a 32-core chip and
getting ready for a release but I should have some time now.

I've got some other patches I also need to submit.

-Aaron

On 04/30/2011 12:12 PM, Wolfgang Denk wrote:
> Dear Aaron Williams,
>
> In message <1302594796-26276-1-git-send-email-aaron.williams@caviumnetworks.com> you wrote:
>> This patch corrects the addresses used when working with Spansion/AMD FLASH
>> chips.  Addressing for 8 and 16 bits is almost identical except in the 16
>> bit case the LSB of the address is always 0.  The confusion arose because
>> the addresses in the datasheet for the 16 bit mode are word addresses but
>> the CFI driver assumed they were byte addresses.
>>
>> I have only been able to test this on our Octeon boards which use either 
>> an 8 or 16 bit bus.  I have not tested 32-bits or when there are multiple
>> parts in parallel on a wider bus.
>>
>> Several other people have also reported success with this patch.
>>
>> -Aaron Williams
>>
>>
>> Signed-off-by: Aaron Williams <aaron.williams@caviumnetworks.com>
>> ---
>>  drivers/mtd/cfi_flash.c |   66 +++++++++++++++++++++++++++++++---------------
>>  include/mtd/cfi_flash.h |   43 ++++++++++++++++--------------
>>  2 files changed, 67 insertions(+), 42 deletions(-)
> This patch has a number of coding style isses (trailing whitespace,
> space between function name and open parenthesis, line over 80
> characters, etc.)
>
> Please clean up and resubmit (after verifying the patch using
> checkpatch).
>
> Best regards,
>
> Wolfgang Denk
>

  reply	other threads:[~2011-04-30 19:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12  7:53 [U-Boot] [PATCH] cfi_flash driver: fixed addressing for 8-bit flash buses Aaron Williams
2011-04-12  8:14 ` Albert ARIBAUD
2011-04-30 19:12 ` Wolfgang Denk
2011-04-30 19:14   ` Aaron Williams [this message]
2011-09-30  8:12     ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DBC5FA9.8030607@caviumnetworks.com \
    --to=aaron.williams@caviumnetworks.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox