[U-Boot] [PATCH 23/30] km/common: replace env var checkboardidlist by function

Wolfgang Denk
2011-05-02T08:43:48Z

Dear Holger Brunck,

In message <4DBE6B91.7090008@keymile.com> you wrote:
>
> > How well has this code been tested? I may not understand it correctly
> > (which might be an indication that some comments are missing that
> > actually explain what you are doing), or there might be some unhandled
> > error cases.
>
> It is tested on our boards. But indeed the commit message should be better to be
> able to understand the functionality. Additionaly we check if additionaly some
> error cases are not handled.

And please comment the _code_!

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Life, loathe it or ignore it, you can't like it."
- Marvin the paranoid android