[U-Boot] [PATCH 06/30] powerpc/km82xx: move SDRAM config to board config

Wolfgang Denk
2011-04-30T07:56:41Z

Dear Valentin Longchamp,

In message <08249e40b548fff1e636cecf980e11adabda14ac.1302272395.git.valentin.longchamp@keymile.com> you wrote:
> From: Holger Brunck <holger.brunck@keymile.com>
>
> To be prepared for mgcoge3ne which has a different SDRAM on board.
> The config was moved from generic code to board specific header.
>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> Acked-by: Heiko Schocher <hs@denx.de>
> cc: Wolfgang Denk <wd@denx.de>
> cc: Detlev Zundel <dzu@denx.de>
> cc: Valentin Longchamp <valentin.longchamp@keymile.com>
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> ---
> include/configs/km82xx-common.h | 26 --------------------------
> include/configs/mgcoge.h | 26 ++++++++++++++++++++++++++
> include/configs/mgcoge2ne.h | 23 +++++++++++++++++++++++
> 3 files changed, 49 insertions(+), 26 deletions(-)

If I'm understanding this right, we now duplicate the definitions into
two files, because two boards happen to use the same SDRAM. Would it
not make more sense to move this into a single copy of a SDRAM
specific header, which then gets included by all boards that use this
SDRAM type? This way we can avoid multiple copied of the same stuff
(which always is a maintenance nightmare) for popular RAM types.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Stupidity, like virtue, is its own reward" - William E. Davidsen