[U-Boot] [PATCH 10/30] arm/km: add addbootcount environment variable

Wolfgang Denk
2011-04-30T08:09:55Z

Dear Valentin Longchamp,

In message <ab89ca576a2ad8bcde3b08039a71a9a7695a7eef.1302272395.git.valentin.longchamp@keymile.com> you wrote:
> From: Holger Brunck <holger.brunck@keymile.com>
>
> This environment variable is used to set the bootcount address
> for the kernel.

"addbootcount" reads to me as "add something to the boot counter". I
do not expect that this has anything to do with an address. Please use
something like "bootcount_addr" (or "bootcnt_addr" or similar)
instead.

> @@ -106,6 +106,13 @@ int set_km_env(void)
> varaddr = gd->ram_size - CONFIG_KM_RESERVED_PRAM - CONFIG_KM_PHRAM;
> sprintf((char *)buf, "0x%x", varaddr);
> setenv("varaddr", (char *)buf);
> +
> +#ifdef BOOTCOUNT_ADDR
> + unsigned int bootcountaddr;
> + bootcountaddr = gd->ram_size - CONFIG_KM_RESERVED_PRAM;
> + sprintf((char *)buf, "0x%x", bootcountaddr);
> + setenv("bootcountaddr", (char *)buf);
> +#endif

NAK. We don't allow declarations in the middle of the code.

> }
>
> diff --git a/include/configs/km_arm.h b/include/configs/km_arm.h
> index 70113d4..89f9d35 100644
> --- a/include/configs/km_arm.h
> +++ b/include/configs/km_arm.h
> @@ -64,6 +64,9 @@
> #define CONFIG_KM_KERNEL_ADDR 0x2000000 /* 4096KBytes */
>
> #define CONFIG_KM_DEF_ENV_CPU \
> + "addbootcount=" \
> + "setenv bootargs ${bootargs} " \
> + "bootcountaddr=${bootcountaddr}\0" \

Argh. Not I see what you mean. Please fix the description,it is
completely misleading.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The number of Unix installations has grown to 10, with more
expected." - The Unix Programmer's Manual, 2nd Edition, June, 1972