From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/3] arm: omap: innovator: Prepare for mach-types.h changes
Date: Tue, 03 May 2011 16:00:01 +0300 [thread overview]
Message-ID: <4DBFFC51.3000206@compulab.co.il> (raw)
In-Reply-To: <20110503122954.4B3EC126DAF@gemini.denx.de>
Hi Wolfgang,
On 05/03/11 15:29, Wolfgang Denk wrote:
> Dear Igor Grinberg,
>
> In message <1304417333-30745-1-git-send-email-grinberg@compulab.co.il> you wrote:
>> This board used machine_is_* macros for identifying the arch number.
>> Fix this by introducing a board specific configuration variable.
>>
>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>> ---
>> v2: remove the ifdeferry by introducing config variable,
>> Alessandro, what about this one?
> ...
>> + gd->bd->bi_arch_number = CONFIG_BOARD_MACH_TYPE;
> In principle this is OK, but why do you invent yet another new CONFIG_
> variable (and without documenting it) ?
Well, it was meant to be board specific, so local documentation in
config file should be enough.
> We have a number of boards that already use a similar construct with
> CONFIG_MACH_TYPE, so I suggest you do the same.
Didn't know that, I though it is new... silly me... ;)
Thanks for pointing.
> And while being there, could you please also add a description for
> CONFIG_MACH_TYPE to the README? Thanks!
I'll try my best, but this will take a while...
Other patches in this series are not affected by this one,
so can be easily applied.
--
Regards,
Igor.
next prev parent reply other threads:[~2011-05-03 13:00 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 12:42 [U-Boot] Update and Cut down mach types Paulraj, Sandeep
2011-04-19 13:39 ` Matthias Weißer
2011-04-19 13:45 ` Paulraj, Sandeep
2011-04-20 8:44 ` Albert ARIBAUD
2011-04-19 14:21 ` Wolfgang Denk
2011-04-19 18:42 ` Matthias Weisser
2011-04-19 18:44 ` Michael Schwingen
2011-04-20 8:15 ` Detlev Zundel
2011-04-20 8:58 ` Igor Grinberg
2011-04-20 17:15 ` Michael Schwingen
2011-04-20 17:49 ` Albert ARIBAUD
2011-04-20 19:26 ` Michael Schwingen
2011-04-21 11:39 ` Albert ARIBAUD
2011-04-26 18:14 ` Michael Schwingen
2011-04-26 19:40 ` Wolfgang Denk
2011-04-26 20:38 ` Albert ARIBAUD
2011-04-26 21:32 ` Wolfgang Denk
2011-04-26 21:38 ` Reinhard Meyer
2011-04-27 10:19 ` Michael Schwingen
2011-04-28 6:20 ` Igor Grinberg
2011-04-29 8:58 ` Detlev Zundel
2011-05-01 10:10 ` [U-Boot] [PATCH 1/3] arm: omap: innovator: fix compilation error Igor Grinberg
2011-05-17 12:40 ` Igor Grinberg
2011-05-21 21:40 ` Paulraj, Sandeep
2011-05-01 10:10 ` [U-Boot] [PATCH 2/3] arm: omap: innovator: Prepare for mach-types.h changes Igor Grinberg
2011-05-01 20:28 ` Alessandro Rubini
2011-05-02 7:18 ` Igor Grinberg
2011-05-03 10:08 ` [U-Boot] [PATCH v2 " Igor Grinberg
2011-05-03 12:29 ` Wolfgang Denk
2011-05-03 13:00 ` Igor Grinberg [this message]
2011-05-04 7:13 ` [U-Boot] [PATCH v3 " Igor Grinberg
2011-05-01 10:10 ` [U-Boot] [PATCH 3/3] arm: at91: ether: " Igor Grinberg
2011-05-01 19:38 ` Reinhard Meyer
2011-05-02 7:29 ` Igor Grinberg
2011-05-02 10:09 ` Detlev Zundel
2011-05-02 12:49 ` [U-Boot] [PATCH v2 " Igor Grinberg
2011-05-16 13:31 ` Igor Grinberg
2011-04-27 11:44 ` [U-Boot] Update and Cut down mach types Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBFFC51.3000206@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox