From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valentin Longchamp Date: Wed, 04 May 2011 10:07:10 +0200 Subject: [U-Boot] [PATCH v2 3/8] arm/km: add BootROM config file for memphis SDRAM In-Reply-To: References: Message-ID: <4DC1092E.4080804@keymile.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Prafulla Wadaskar wrote: > >> -----Original Message----- >> From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com] >> Sent: Tuesday, May 03, 2011 7:43 PM >> To: u-boot at lists.denx.de >> Cc: Prafulla Wadaskar; holger.brunck at keymile.com; Valentin Longchamp; >> Wolfgang Denk; Detlev Zundel >> Subject: [PATCH v2 3/8] arm/km: add BootROM config file for memphis >> SDRAM >> >> This RAM is used on mgcoge3un and needs other initialization values >> for the SDRAM controller. >> >> Signed-off-by: Valentin Longchamp >> Signed-off-by: Holger Brunck >> Acked-by: Heiko Schocher >> cc: Prafulla Wadaskar >> cc: Wolfgang Denk >> cc: Detlev Zundel >> --- >> Changes for v2: >> - split up first large patch series to three independent smaller >> patch series >> >> board/keymile/km_arm/kwbimage-memphis.cfg | 197 >> +++++++++++++++++++++++++++++ >> 1 files changed, 197 insertions(+), 0 deletions(-) >> create mode 100644 board/keymile/km_arm/kwbimage-memphis.cfg >> > > You are just adding file here, whereas it is not being used. Is it like dead code to me. > Yes, it is not used with the u-boot build system, we have a small script that wraps around it. It is used by the mgcoge3un board, that is later introduced with this series. Your remark makes me think I have a few things to change in our marvell boards config: 1) We currently define CONFIG_SYS_KWD_CONFIG in include/configs/keymile-common.h, although this is stricly used by our marvell/kirkwood designs -> we shoud move this definition to include/configs/km_arm.h 2) I should add redefine CONFIG_SYS_KWD_CONFIG to this kwbiamge-memphis.cfg for mgcoge3un board Now I have a question about the marvell boards build: I see in the Makefile that there is a rule about this kwb file, which is exactly what we do in our additionnal build script: $(obj)u-boot.kwb: $(obj)u-boot.bin $(obj)tools/mkimage -n $(CONFIG_SYS_KWD_CONFIG) -T kwbimage \ -a $(CONFIG_SYS_TEXT_BASE) -e $(CONFIG_SYS_TEXT_BASE) -d $< $ How do you use it (because I think it is not called by the default make command) ? Regards -- Valentin Longchamp Embedded Software Engineer Hardware and Chip Integration ______________________________________ KEYMILE AG Schwarzenburgstr. 73 CH-3097 Liebefeld Phone +41 31 377 1318 Fax +41 31 377 1212 valentin.longchamp@keymile.com www.keymile.com ______________________________________ KEYMILE: A Specialist as a Partner