From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 7/8] arm/km: change default settings for egiga on mgcoge3un
Date: Wed, 04 May 2011 10:08:18 +0200 [thread overview]
Message-ID: <4DC10972.1060008@keymile.com> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19FAC25C77@SC-VEXCH4.marvell.com>
Prafulla Wadaskar wrote:
>
>> -----Original Message-----
>> From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
>> Sent: Tuesday, May 03, 2011 7:43 PM
>> To: u-boot at lists.denx.de
>> Cc: Prafulla Wadaskar; holger.brunck at keymile.com; Valentin Longchamp;
>> Wolfgang Denk; Detlev Zundel
>> Subject: [PATCH v2 7/8] arm/km: change default settings for egiga on
>> mgcoge3un
>>
>> From: Holger Brunck <holger.brunck@keymile.com>
>>
>> The reason we need this is that we have the gig port on mgcoge3un
>> connected using a back-to-back pair of PHYs. There are no magnetics and
>> because of that the port has to be run with a fixd configuration and
>> auto-negotiation must be disabled. In the default mode the egiga driver
>> uses autoneg to determine port speed - which defaults to 1G (we need
>> 100M full duplex).
>>
>> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
>> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
>> Acked-by: Heiko Schocher <hs@denx.de>
>> Acked-by: Prafulla Wadaskar <Prafulla@marvell.com>
>> cc: Wolfgang Denk <wd@denx.de>
>> cc: Detlev Zundel <dzu@denx.de>
>> ---
>> Changes for v2:
>> - split up first large patch series to three independent smaller
>> patch series
>>
>> drivers/net/mvgbe.h | 2 ++
>> include/configs/mgcoge3un.h | 25 +++++++++++++++++++++++++
>
> It will be good if you split this patch, the mvgbe.h change would be generic, independent and can be merged faster.
>
> mgcoge3un.h changes would be part of your new board config.
>
Ok, I agree, I will split them.
Regards
--
Valentin Longchamp
Embedded Software Engineer
Hardware and Chip Integration
______________________________________
KEYMILE AG
Schwarzenburgstr. 73
CH-3097 Liebefeld
Phone +41 31 377 1318
Fax +41 31 377 1212
valentin.longchamp at keymile.com
www.keymile.com
______________________________________
KEYMILE: A Specialist as a Partner
next prev parent reply other threads:[~2011-05-04 8:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 14:13 [U-Boot] [PATCH v2 0/8] keymile arm boards update, part 2 Valentin Longchamp
2011-05-03 14:13 ` [U-Boot] [PATCH v2 1/8] arm/km: introduce and manage bootcount environment variable Valentin Longchamp
2011-05-03 14:13 ` [U-Boot] [PATCH v2 2/8] arm/km: remove last_stage_init and unneeded printouts Valentin Longchamp
2011-05-04 7:30 ` Prafulla Wadaskar
2011-05-04 7:43 ` Valentin Longchamp
2011-05-03 14:13 ` [U-Boot] [PATCH v2 3/8] arm/km: add BootROM config file for memphis SDRAM Valentin Longchamp
2011-05-04 7:30 ` Prafulla Wadaskar
2011-05-04 8:07 ` Valentin Longchamp
2011-05-04 22:22 ` Wolfgang Denk
2011-05-05 6:28 ` Valentin Longchamp
2011-05-03 14:13 ` [U-Boot] [PATCH v2 4/8] arm/km: disable ls (through jffs2 support) Valentin Longchamp
2011-05-04 7:30 ` Prafulla Wadaskar
2011-05-03 14:13 ` [U-Boot] [PATCH v2 5/8] arm/km: add second serial interface for kirkwood Valentin Longchamp
2011-05-03 14:13 ` [U-Boot] [PATCH v2 6/8] arm/km: rename mgcoge2un to mgcoge3un Valentin Longchamp
2011-05-04 7:30 ` Prafulla Wadaskar
2011-05-04 8:35 ` Valentin Longchamp
2011-05-04 22:17 ` Wolfgang Denk
2011-05-05 6:18 ` Valentin Longchamp
2011-05-03 14:13 ` [U-Boot] [PATCH v2 7/8] arm/km: change default settings for egiga on mgcoge3un Valentin Longchamp
2011-05-04 6:58 ` Prafulla Wadaskar
2011-05-04 8:08 ` Valentin Longchamp [this message]
2011-05-04 22:15 ` Wolfgang Denk
2011-05-03 14:13 ` [U-Boot] [PATCH v2 8/8] arm/km: update mgcoge3un board support Valentin Longchamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC10972.1060008@keymile.com \
--to=valentin.longchamp@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox