From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Ceresoli <luca.ceresoli@comelit.it>
Date: Wed, 04 May 2011 18:42:30 +0200
Subject: [U-Boot] [PATCH 2/8] net/net.c: cosmetic: variable
	initializations
In-Reply-To: <BANLkTim3Lk=NJjNF4v-e4iA9p2uNXYaOsg@mail.gmail.com>
References: <1304512847-7351-1-git-send-email-luca.ceresoli@comelit.it>
	<1304512847-7351-3-git-send-email-luca.ceresoli@comelit.it>
	<BANLkTim3Lk=NJjNF4v-e4iA9p2uNXYaOsg@mail.gmail.com>
Message-ID: <4DC181F6.8000306@comelit.it>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Mike Frysinger wrote:
> On Wed, May 4, 2011 at 08:40, Luca Ceresoli wrote:
>>   - ERROR: that open brace { should be on the previous line
>> ...
>> -uchar          NetCDPAddr[6] =
>> -                       { 0x01, 0x00, 0x0c, 0xcc, 0xcc, 0xcc };
>> +uchar          NetCDPAddr[6] = {
>> +                       0x01, 0x00, 0x0c, 0xcc, 0xcc, 0xcc };
>> ...
> your fix here is worse than the original.  just leave them be.

Damn, you're right!

I think a one-line solution would be even better (and much simpler):

uchar           NetCDPAddr[6] = {0x01, 0x00, 0x0c, 0xcc, 0xcc, 0xcc};

BTW, this is the original checkpatch message:
   ERROR: that open brace { should be on the previous line
   #172: FILE: net.c:172:
   +uchar          NetCDPAddr[6] =
   +                       { 0x01, 0x00, 0x0c, 0xcc, 0xcc, 0xcc };

So either we choose the one-line solution above, or we have the first
checkpatch message that should be disabled in the U-Boot version, when it
will exist.

Your opinion?

Luca