From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valentin Longchamp Date: Thu, 05 May 2011 08:18:36 +0200 Subject: [U-Boot] [PATCH v2 6/8] arm/km: rename mgcoge2un to mgcoge3un In-Reply-To: <20110504221757.EA153126DAA@gemini.denx.de> References: <4DC10FEC.1050200@keymile.com> <20110504221757.EA153126DAA@gemini.denx.de> Message-ID: <4DC2413C.1070705@keymile.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang Denk, Wolfgang Denk wrote: > Dear Valentin Longchamp, > > In message <4DC10FEC.1050200@keymile.com> you wrote: >> The current differences between our kirkwood boards are not many, but >> since we have new boards coming where the difference number is going to >> grow, it is going to be hard to keep many (even 2) boards in one single >> file. That why we prefer to have the differences (and common source code >> we have to maintain, I agree as well) in .h source files than in the >> boards.cfg file. > > Oops. Common _source_ code in ".h source files" ? > > Please don't. Header files are NOT intended for any real source code > (with th exception of some usually smallish inline fnctions and such). > Well, the _source_ code expression is a language abuse in this case. There is no real source code in these files, only some defines, and I have even reduced the number of them in the last iteration of the patch series. Best Regards -- Valentin Longchamp Embedded Software Engineer Hardware and Chip Integration ______________________________________ KEYMILE AG Schwarzenburgstr. 73 CH-3097 Liebefeld Phone +41 31 377 1318 Fax +41 31 377 1212 valentin.longchamp at keymile.com www.keymile.com ______________________________________ KEYMILE: A Specialist as a Partner