From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valentin Longchamp Date: Thu, 05 May 2011 08:28:36 +0200 Subject: [U-Boot] [PATCH v2 3/8] arm/km: add BootROM config file for memphis SDRAM In-Reply-To: <20110504222234.6FF96126DAA@gemini.denx.de> References: <4DC1092E.4080804@keymile.com> <20110504222234.6FF96126DAA@gemini.denx.de> Message-ID: <4DC24394.8060904@keymile.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Valentin Longchamp, > > In message <4DC1092E.4080804@keymile.com> you wrote: >>> You are just adding file here, whereas it is not being used. Is it like dead code to me. >> Yes, it is not used with the u-boot build system, we have a small script >> that wraps around it. > > As this "small script" is neither available here this _is_ dead code > and will not be accepted. Yes I completely agree. That's why we have some other config files that were initially posted for mainline inclusion and removed for this patch series. > >> It is used by the mgcoge3un board, that is later introduced with this >> series. > > Then please add it together with this board, then. That's what I have done in the v3 series posted yesterday. > >> Now I have a question about the marvell boards build: I see in the >> Makefile that there is a rule about this kwb file, which is exactly what >> we do in our additionnal build script: > > Please either get rid of this "additionnal build script", or move it's > function into the mainline U-Boot code. I agree once again. I have asked Prafulla for additionnal information about the mkimage usage in the standard u-boot Makefile (because this is new for us in u-boot). If we can use this, we then can simplify the given build script (or even get rid of it). I first have to clarify things about this build script with my colleagues. > > (Note: this might even be considered as a GPL violation which > requires to include "scripts used to control compilation"). > Well, no violation intended here. This script can be published. But I have to clarify with my colleagues why exactly we have to script additionally to the standard u-boot Makefile (it may only be legacy because we used to work with an old u-boot before our mainlining effort). Best Regards -- Valentin Longchamp Embedded Software Engineer Hardware and Chip Integration ______________________________________ KEYMILE AG Schwarzenburgstr. 73 CH-3097 Liebefeld Phone +41 31 377 1318 Fax +41 31 377 1212 valentin.longchamp at keymile.com www.keymile.com ______________________________________ KEYMILE: A Specialist as a Partner