public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Timur Tabi <b04825@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/mpc8xxx: reword max tCKmin message
Date: Thu, 5 May 2011 10:04:18 -0500	[thread overview]
Message-ID: <4DC2BC72.90205@freescale.com> (raw)
In-Reply-To: <341138D6-917F-400E-BE08-73F9A6246AB9@kernel.crashing.org>

Kumar Gala wrote:
>>> >> That still needs some work, IMHO.  I think you might need the word
>>> >> "which" before "doesn't".  However, even with that, it's not clear
>>> >> what's wrong.  Where does the bad value of "mclk_ps" come from?
>>> >> 
>> > 
>> > It happens when the actually DDR clock is faster than the slowest DIMM
>> > can support.
>> > 
>> > York
> Did you guys agree on wording?  Is the patch ok or needs changing?

I haven't seen an updated patch from York.  I'd like to see the addition of text
like, "It happens when the actually DDR clock is faster than the slowest DIMM
can support."  People need to know what to fix, not just what's wrong.

Also, %d is for signed integers, not unsigned.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2011-05-05 15:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-03  1:51 [U-Boot] [PATCH] powerpc/mpc8xxx: reword max tCKmin message York Sun
2011-05-03  3:19 ` Tabi Timur-B04825
2011-05-03  3:40   ` York Sun
2011-05-05 14:09     ` Kumar Gala
2011-05-05 15:04       ` Timur Tabi [this message]
2011-05-05 22:45         ` York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC2BC72.90205@freescale.com \
    --to=b04825@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox