From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Thu, 5 May 2011 10:04:18 -0500 Subject: [U-Boot] [PATCH] powerpc/mpc8xxx: reword max tCKmin message In-Reply-To: <341138D6-917F-400E-BE08-73F9A6246AB9@kernel.crashing.org> References: <1304387509-25357-1-git-send-email-yorksun@freescale.com> <1304394018.18283.42.camel@oslab-l1> <341138D6-917F-400E-BE08-73F9A6246AB9@kernel.crashing.org> Message-ID: <4DC2BC72.90205@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Kumar Gala wrote: >>> >> That still needs some work, IMHO. I think you might need the word >>> >> "which" before "doesn't". However, even with that, it's not clear >>> >> what's wrong. Where does the bad value of "mclk_ps" come from? >>> >> >> > >> > It happens when the actually DDR clock is faster than the slowest DIMM >> > can support. >> > >> > York > Did you guys agree on wording? Is the patch ok or needs changing? I haven't seen an updated patch from York. I'd like to see the addition of text like, "It happens when the actually DDR clock is faster than the slowest DIMM can support." People need to know what to fix, not just what's wrong. Also, %d is for signed integers, not unsigned. -- Timur Tabi Linux kernel developer at Freescale