From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Ceresoli Date: Tue, 10 May 2011 09:13:44 +0200 Subject: [U-Boot] [PATCH 1/8] net/net.c: cosmetic: fix lines over 80 characters In-Reply-To: <201105091542.04858.vapier@gentoo.org> References: <1304512847-7351-1-git-send-email-luca.ceresoli@comelit.it> <1304512847-7351-2-git-send-email-luca.ceresoli@comelit.it> <201105091542.04858.vapier@gentoo.org> Message-ID: <4DC8E5A8.1090203@comelit.it> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Mike, Mike Frysinger wrote: > On Wednesday, May 04, 2011 08:40:40 Luca Ceresoli wrote: >> - debug("Got ICMP ECHO REQUEST, return %d bytes \n", >> - ETHER_HDR_SIZE + len); >> + debug("Got ICMP ECHO REQUEST, " >> + "return %d bytes \n", >> + ETHER_HDR_SIZE + len); > please do not split string literals What do you suggest as an alternative? Leave the line more than 80 characters long? I think the best thing would be to split the NetReceive() function that contains that line, which is currently ~400 lines long. This would reduce the amount of tabs in front of the deeply nested lines (such as this). So I would agree to leave the line as is, waiting for NetReceive() to be split in a future cleanup work. Luca