From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mvsata: issue hard reset on initialization
Date: Wed, 11 May 2011 07:23:57 +0200 [thread overview]
Message-ID: <4DCA1D6D.2000306@aribaud.net> (raw)
In-Reply-To: <201105110013.30356.michael@walle.cc>
Hi Michael,
Le 11/05/2011 00:13, Michael Walle a ?crit :
>
> Hi Albert,
>
> Am Dienstag 10 Mai 2011, 23:47:04 schrieben Sie:
>> Hi Michael,
>>
>> Sorry for the delay. Busy period for me I'm afraid.
> no problem ;)
>
>> Le 09/05/2011 19:49, Michael Walle a ?crit :
>>> Am Montag 02 Mai 2011, 10:37:41 schrieb Prafulla Wadaskar:
>>>>> -----Original Message-----
>>>>> From: Michael Walle [mailto:michael at walle.cc]
>>>>> Sent: Monday, May 02, 2011 3:35 AM
>>>>> To: u-boot at lists.denx.de
>>>>> Cc: Michael Walle; Prafulla Wadaskar
>>>>> Subject: [PATCH] mvsata: issue hard reset on initialization
>>>>>
>>>>> Before the actual initialization do a hard reset of the SATA port and
>>>>> the
>>>>> connected device.
>>>>
>>>> Copying Albert for his ack
>>>
>>> any news on this?
>>
>> What is the reason for issuing the hard reset? Is it in case the board
>> was rebooted and we want the disk drives to return to a safe state?
> Right, if i reboot my linkstation (from linux) the ATA probing times out
> without the reset.
>
> Also, the user manual states (FS_88F6180_9x_6281_OpenSource.pdf, Ch 7.6.9):
> Device hard reset (setting the<eAtaRst> field in the EDMA Command Register
> (Table 342 p. 506) and device initialization are required before any attempt
> to access the device.
Ok.
>> Also, why 25?
> I took that 25us from the original marvell uboot port (uboot 1.1.4 heavily
> modified by marvell, the gpl sources provided by buffalo) and from the linux
> sata_mv driver, both are using 25us.
Can you just add a comment stating that the value was inspired by
Marvell use rather than taken from the spec?
Amicalement,
--
Albert.
prev parent reply other threads:[~2011-05-11 5:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-01 22:04 [U-Boot] [PATCH] mvsata: issue hard reset on initialization Michael Walle
2011-05-02 8:37 ` Prafulla Wadaskar
2011-05-09 17:49 ` Michael Walle
2011-05-10 21:47 ` Albert ARIBAUD
2011-05-10 22:13 ` Michael Walle
2011-05-11 5:23 ` Albert ARIBAUD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCA1D6D.2000306@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox