From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Wed, 11 May 2011 07:23:57 +0200 Subject: [U-Boot] [PATCH] mvsata: issue hard reset on initialization In-Reply-To: <201105110013.30356.michael@walle.cc> References: <201105091949.08079.michael@walle.cc> <4DC9B258.3030703@aribaud.net> <201105110013.30356.michael@walle.cc> Message-ID: <4DCA1D6D.2000306@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Michael, Le 11/05/2011 00:13, Michael Walle a ?crit : > > Hi Albert, > > Am Dienstag 10 Mai 2011, 23:47:04 schrieben Sie: >> Hi Michael, >> >> Sorry for the delay. Busy period for me I'm afraid. > no problem ;) > >> Le 09/05/2011 19:49, Michael Walle a ?crit : >>> Am Montag 02 Mai 2011, 10:37:41 schrieb Prafulla Wadaskar: >>>>> -----Original Message----- >>>>> From: Michael Walle [mailto:michael at walle.cc] >>>>> Sent: Monday, May 02, 2011 3:35 AM >>>>> To: u-boot at lists.denx.de >>>>> Cc: Michael Walle; Prafulla Wadaskar >>>>> Subject: [PATCH] mvsata: issue hard reset on initialization >>>>> >>>>> Before the actual initialization do a hard reset of the SATA port and >>>>> the >>>>> connected device. >>>> >>>> Copying Albert for his ack >>> >>> any news on this? >> >> What is the reason for issuing the hard reset? Is it in case the board >> was rebooted and we want the disk drives to return to a safe state? > Right, if i reboot my linkstation (from linux) the ATA probing times out > without the reset. > > Also, the user manual states (FS_88F6180_9x_6281_OpenSource.pdf, Ch 7.6.9): > Device hard reset (setting the field in the EDMA Command Register > (Table 342 p. 506) and device initialization are required before any attempt > to access the device. Ok. >> Also, why 25? > I took that 25us from the original marvell uboot port (uboot 1.1.4 heavily > modified by marvell, the gpl sources provided by buffalo) and from the linux > sata_mv driver, both are using 25us. Can you just add a comment stating that the value was inspired by Marvell use rather than taken from the spec? Amicalement, -- Albert.