From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] omap4: add support for gpios
Date: Fri, 13 May 2011 07:26:10 +0200 [thread overview]
Message-ID: <4DCCC0F2.1020906@xenomai.org> (raw)
In-Reply-To: <BANLkTiks8-CZtdccNbvfdvDnQEHjoVS-tw@mail.gmail.com>
On 05/10/2011 04:08 PM, John Rigby wrote:
> On Mon, May 9, 2011 at 11:04 PM, Gilles Chanteperdrix
> <gilles.chanteperdrix@xenomai.org> wrote:
>> Copied from omap3.
> I have not looked at the code but if it truly is a copy (other than
> some base addresses) is there a way to share with omap3?
I am going to fix this and resend another round of patches. But, it this
the only thing I should fix?
For instance, in part of the patch, I used hardcoded hardware addresses,
in other part, I put some #define for register addresses in the .c file,
in other part, the #define are in a common header. What is the policy in
u-boot for this particular point?
--
Gilles.
next prev parent reply other threads:[~2011-05-13 5:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 21:02 [U-Boot] tftp booting the panda board Gilles Chanteperdrix
2011-05-09 21:04 ` [U-Boot] [PATCH 1/3] omap4: add support for gpios Gilles Chanteperdrix
2011-05-10 14:08 ` John Rigby
2011-05-10 18:58 ` Gilles Chanteperdrix
2011-05-13 5:26 ` Gilles Chanteperdrix [this message]
2011-05-13 5:31 ` John Rigby
2011-05-13 5:35 ` Gilles Chanteperdrix
2011-05-09 21:04 ` [U-Boot] [PATCH 2/3] omap4: add support for EHCI Gilles Chanteperdrix
2011-05-18 19:50 ` John Rigby
2011-05-18 19:58 ` Gilles Chanteperdrix
2011-05-18 20:42 ` Wolfgang Denk
2011-05-09 21:04 ` [U-Boot] [PATCH 3/3] omap4_panda: " Gilles Chanteperdrix
2011-05-09 22:30 ` [U-Boot] tftp booting the panda board Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCCC0F2.1020906@xenomai.org \
--to=gilles.chanteperdrix@xenomai.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox