From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gilles Chanteperdrix Date: Fri, 13 May 2011 07:26:10 +0200 Subject: [U-Boot] [PATCH 1/3] omap4: add support for gpios In-Reply-To: References: <4DC85670.3070300@xenomai.org> <1304975091-21848-1-git-send-email-gilles.chanteperdrix@xenomai.org> Message-ID: <4DCCC0F2.1020906@xenomai.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/10/2011 04:08 PM, John Rigby wrote: > On Mon, May 9, 2011 at 11:04 PM, Gilles Chanteperdrix > wrote: >> Copied from omap3. > I have not looked at the code but if it truly is a copy (other than > some base addresses) is there a way to share with omap3? I am going to fix this and resend another round of patches. But, it this the only thing I should fix? For instance, in part of the patch, I used hardcoded hardware addresses, in other part, I put some #define for register addresses in the .c file, in other part, the #define are in a common header. What is the policy in u-boot for this particular point? -- Gilles.