From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2] bootp: add ntpserver option to bootp request
Date: Mon, 16 May 2011 15:57:49 +0400 [thread overview]
Message-ID: <4DD1113D.8070806@mvista.com> (raw)
In-Reply-To: <1305512681-8167-1-git-send-email-judge.packham@gmail.com>
Hello.
On 16-05-2011 6:24, Chris Packham wrote:
> From: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
> Signed-off-by: Luuk Paulussen<luuk.paulussen@alliedtelesis.co.nz>
> Acked-by: Chris Packham<chris.packham@alliedtelesis.co.nz>
> Cc: Ben Warren<biggerbadderben@gmail.com>
[...]
> diff --git a/net/bootp.c b/net/bootp.c
> index 4db63cb..18c743e 100644
> --- a/net/bootp.c
> +++ b/net/bootp.c
> @@ -228,6 +228,11 @@ static void BootpVendorFieldProcess (u8 * ext)
> NetOurNISDomain[size] = 0;
> }
> break;
> +#if defined(CONFIG_CMD_SNTP)&& defined(CONFIG_BOOTP_NTPSERVER)
> + case 42: /* NTP server IP */
> + NetCopyIP (&NetNtpServerIP, (IPaddr_t *) (ext + 2));
There should be no space between function name and (. You're now supposed
to run your patch thru scripts/checkpatch.pl (from Linux source tree).
> + break;
> +#endif
> /* Application layer fields */
> case 43: /* Vendor specific info - Not yet supported */
> /*
> @@ -538,6 +548,11 @@ static int BootpExtended (u8 * e)
> *e++ = 32;
> e += 32;
> #endif
> +#if defined(CONFIG_BOOTP_NTPSERVER)
> + *e++ = 42;
Too many spaces...
> + *e++ = 4;
> + e += 4;
> +#endif
WBR, Sergei
next prev parent reply other threads:[~2011-05-16 11:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 1:29 [U-Boot] [PATCH 1/3] rtc: add driver for internal RTC on kirkwood SoC Chris Packham
2011-05-13 1:29 ` [U-Boot] [PATCH 2/3] sntp: avoid use of uninitialized variable Chris Packham
2011-05-13 1:29 ` [U-Boot] [PATCH 3/3] bootp: add ntpserver option to bootp request Chris Packham
2011-05-13 1:33 ` Chris Packham
2011-05-16 2:24 ` [U-Boot] [PATCHv2] " Chris Packham
2011-05-16 11:57 ` Sergei Shtylyov [this message]
2011-05-17 4:09 ` Chris Packham
2011-05-17 4:29 ` [U-Boot] [PATCHv3] " Chris Packham
2011-07-27 21:20 ` Wolfgang Denk
2011-05-13 1:34 ` [U-Boot] [PATCH 2/3] sntp: avoid use of uninitialized variable Chris Packham
2011-05-17 4:27 ` [U-Boot] [PATCHv2] " Chris Packham
2011-05-17 8:32 ` Detlev Zundel
2011-05-13 1:32 ` [U-Boot] [PATCH 1/3] rtc: add driver for internal RTC on kirkwood SoC Chris Packham
2011-05-17 4:25 ` [U-Boot] [PATCHv2] " Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD1113D.8070806@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox