From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aneesh V <aneesh@ti.com>
Date: Mon, 16 May 2011 19:40:30 +0530
Subject: [U-Boot] [PATCH v2 08/22] omap: add spl support
In-Reply-To: <20110515195208.EA0971491B06@gemini.denx.de>
References: <1298893591-17636-1-git-send-email-aneesh@ti.com>
	<1305472900-4004-9-git-send-email-aneesh@ti.com>
	<20110515195208.EA0971491B06@gemini.denx.de>
Message-ID: <4DD13056.3000509@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On Monday 16 May 2011 01:22 AM, Wolfgang Denk wrote:
> Dear Aneesh V,
>
> In message<1305472900-4004-9-git-send-email-aneesh@ti.com>  you wrote:
>> Add the basic spl framework and linker script common for OMAP3/4
>> platforms.
>>
>> Signed-off-by: Aneesh V<aneesh@ti.com>
>> ---
>>   spl/board/ti/spl-omap.c   |   47 ++++++++++++++++++++++++++++++++++
>>   spl/board/ti/spl-omap.lds |   62 +++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 109 insertions(+), 0 deletions(-)
>>   create mode 100644 spl/board/ti/spl-omap.c
>>   create mode 100644 spl/board/ti/spl-omap.lds
>
> Again, this appears to be not the right order.
>
> I think, in the first step of this series, we should move the existing
> code from nand_spl and onenand_ipl into something like spl/nand and
> spl/onenand, respectivly, and make sure all teh existing systems still
> build.  The we can add more such support.

IMHO, we should just have spl/board/<vendor>/<board>/ .

Let spl/board/<vendor>/<board>/Makefile decide what it wants to
build.

I mean something like this(similar changes for ONENAND):

+.PHONEY : SPL
+SPL	:$(TIMESTAMP_FILE) $(VERSION_FILE) depend tools
+	$(MAKE) -C spl/board/$(BOARDDIR) all
+
+ifeq ($(CONFIG_SPL),y)
+ALL += SPL
+endif
+
  __OBJS := $(subst $(obj),,$(OBJS))
  __LIBS := $(subst $(obj),,$(LIBS)) $(subst $(obj),,$(LIBBOARD))

@@ -401,11 +409,8 @@ $(LDSCRIPT):	depend
  $(obj)u-boot.lds: $(LDSCRIPT)
  		$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -ansi -D__ASSEMBLY__ -P - <$^ >$@

-nand_spl:	$(TIMESTAMP_FILE) $(VERSION_FILE) depend
-		$(MAKE) -C nand_spl/board/$(BOARDDIR) all
-
-$(obj)u-boot-nand.bin:	nand_spl $(obj)u-boot.bin
-		cat $(obj)nand_spl/u-boot-spl-16k.bin $(obj)u-boot.bin > 
$(obj)u-boot-nand.bin
+$(obj)u-boot-nand.bin:	SPL $(obj)u-boot.bin
+		cat $(obj)spl/u-boot-spl-16k.bin $(obj)u-boot.bin > $(obj)u-boot-nand.bin


>
> Best regards,
>
> Wolfgang Denk
>