From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 17 May 2011 12:02:10 +0200 Subject: [U-Boot] [PATCH V2] MX31: Make get_reset_cause() static In-Reply-To: References: <1305539647-12222-1-git-send-email-sbabic@denx.de> Message-ID: <4DD247A2.2000104@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/17/2011 07:10 AM, Jason Liu wrote: > Hi, Stefano, > Hi Jason, > But looking at the code bellow, beside we need make the function static, > do we need to remove the break after the return statement? Otherwise, > some complier may warn un-reachable code, IMHO. You are right, and the break statement is useless. I have not seen any warnings when I have merged, probably because I still use an older gcc version. I will fix it in the same patch and repost. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================