From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/3] MX5: Make the weim structure complete
Date: Tue, 17 May 2011 14:44:58 +0200 [thread overview]
Message-ID: <4DD26DCA.606@denx.de> (raw)
In-Reply-To: <BANLkTik-MU2bUxKTpW+jp9NyjOnkx1wu9w@mail.gmail.com>
On 05/17/2011 07:06 AM, Jason Liu wrote:
> Hi, Fabio,
>
> 2011/5/17 Fabio Estevam <fabio.estevam@freescale.com>:
>> Make the weim register set complete for MX51/MX53.
>>
>> While at it also add the weim chip select 1 address definition.
>>
>
> From the code, you just add the cs for mx53 not for mx51, so,
> Had better specify you add the cs1 address definition for mx53,
> otherwise, it will make confusion.
Sure ? The structure is not protected by any CONFIG_MX5x switch, and at
least one mx51 board uses it. The registers have the same layout for
both processor. Why do you think is only for MX53 ?
Regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-05-17 12:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 22:29 [U-Boot] [PATCH v2 1/3] MX5: Make the weim structure complete Fabio Estevam
2011-05-16 22:29 ` [U-Boot] [PATCH v2 2/3] MX5: Add iomux structure Fabio Estevam
2011-05-16 22:29 ` [U-Boot] [PATCH v2 3/3] MX53: Add initial support for MX53ARD board Fabio Estevam
2011-05-17 4:43 ` Jason Liu
2011-05-17 13:10 ` Stefano Babic
2011-05-17 4:55 ` [U-Boot] [PATCH v2 2/3] MX5: Add iomux structure Jason Liu
2011-05-17 12:53 ` Stefano Babic
2011-05-17 5:06 ` [U-Boot] [PATCH v2 1/3] MX5: Make the weim structure complete Jason Liu
2011-05-17 12:44 ` Stefano Babic [this message]
2011-05-17 12:58 ` Fabio Estevam
2011-05-17 13:12 ` Stefano Babic
2011-05-17 12:42 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD26DCA.606@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox