From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Date: Tue, 17 May 2011 09:58:28 -0300 Subject: [U-Boot] [PATCH v2 1/3] MX5: Make the weim structure complete In-Reply-To: <4DD26DCA.606@denx.de> References: <1305584991-13040-1-git-send-email-fabio.estevam@freescale.com> <4DD26DCA.606@denx.de> Message-ID: <4DD270F4.90204@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, On 5/17/2011 9:44 AM, Stefano Babic wrote: > On 05/17/2011 07:06 AM, Jason Liu wrote: >> Hi, Fabio, >> >> 2011/5/17 Fabio Estevam : >>> Make the weim register set complete for MX51/MX53. >>> >>> While at it also add the weim chip select 1 address definition. >>> >> >> From the code, you just add the cs for mx53 not for mx51, so, >> Had better specify you add the cs1 address definition for mx53, >> otherwise, it will make confusion. > > Sure ? The structure is not protected by any CONFIG_MX5x switch, and at > least one mx51 board uses it. The registers have the same layout for > both processor. Why do you think is only for MX53 ? I think what Jason mentions is the fact that I added: #define CS1_BASE_ADDR 0xF4000000 and this was only for MX53 because it is protected by "elif defined(CONFIG_MX53)" I can add the CS1_BASE_ADDR for MX51 as well on my v3 series. The weim layout registers are the same for MX51 and MX53. Regards, Fabi Estevam