From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aneesh V Date: Wed, 18 May 2011 10:35:56 +0530 Subject: [U-Boot] [PATCH v2 08/22] omap: add spl support In-Reply-To: <20110516133934.60aa2bc0@schlenkerla.am.freescale.net> References: <1298893591-17636-1-git-send-email-aneesh@ti.com> <1305472900-4004-9-git-send-email-aneesh@ti.com> <20110515195208.EA0971491B06@gemini.denx.de> <4DD13056.3000509@ti.com> <20110516133934.60aa2bc0@schlenkerla.am.freescale.net> Message-ID: <4DD353B4.5090202@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Scott, On Tuesday 17 May 2011 12:09 AM, Scott Wood wrote: > On Mon, 16 May 2011 19:40:30 +0530 > Aneesh V wrote: > >> Hi Wolfgang, >> >> On Monday 16 May 2011 01:22 AM, Wolfgang Denk wrote: >>> I think, in the first step of this series, we should move the existing >>> code from nand_spl and onenand_ipl into something like spl/nand and >>> spl/onenand, respectivly, and make sure all teh existing systems still >>> build. The we can add more such support. >> >> IMHO, we should just have spl/board/// . >> >> Let spl/board///Makefile decide what it wants to >> build. > > That's what we do in nand_spl/onenand_spl -- the common files are more like > libraries that the board makefile may or may not pull in (e.g. many > Freescale boards use nand_boot_fsl_elbc.c or nand_boot_fsl_nfc.c instead of > nand_boot.c). > > Renaming nand_spl seems like it should be the first step. > >> I mean something like this(similar changes for ONENAND): >> >> +.PHONEY : SPL > > .PHONY Oops! I wonder how it was working then. My real patch too had the same mistake! best regards, Aneesh