From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 19 May 2011 14:04:57 +0200 Subject: [U-Boot] [PATCH v3 3/4] MX5: Introduce a function for setting the chip select size In-Reply-To: References: <1305751670-30808-1-git-send-email-fabio.estevam@freescale.com> <1305751670-30808-2-git-send-email-fabio.estevam@freescale.com> <1305751670-30808-3-git-send-email-fabio.estevam@freescale.com> <4DD4D8DA.1030205@denx.de> Message-ID: <4DD50769.70009@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/19/2011 01:49 PM, Fabio Estevam wrote: > Hi Stefano, > Hi Fabio, >> >> mmmhhh...it seems to me not complete, because not all combinations are >> covered. > > Yes, it is complete. Only these four combinations are allowed as per > the MX53 Reference Manual. > >> And setting fixed values in the switch constraints us to have >> very long defines, as CS0_32M_CS1_32M_CS2_32M_CS3_32M. > > I can change the very long defines if you want. > > I thought initially on doing the generic function as you described, > but then we would need to check for only the 4 valid combinations. > Then I came with this implementation that only handle the 4 possible > cases. I made the same mistake and I was convinced that all combinations are possible. I understand why you changed in this way and I agree with this implementation, thanks for clarification. Acked-by: Stefano Babic Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================