From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] AT91: CFI support broken
Date: Fri, 20 May 2011 13:54:11 +0200 [thread overview]
Message-ID: <4DD65663.1070802@emk-elektronik.de> (raw)
In-Reply-To: <4DD647B7.2050706@bus-elektronik.de>
Dear esw at bus-elektronik.de,
> Hello,
>
> since "AT91: fix timer.c - remove reset_timer()"
>
> <http://git.denx.de/?p=u-boot/u-boot-atmel.git;a=commit;h=cfff263f41e32c7ba2ee9162a8cc6423eb5a8390>
>
> was commited the arm926ejs/at91 boards can't compile with cfi_flash support:
>
> u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'
>
> I think this patch should be revert, as long as other modules need the
> reset_timer function.
>
> Can anybody confirm this
I think we should fix the place where reset_timer() is still used, to use get_timer() only.
All other drivers that are used in atmel context do not use reset_timer(), but rely on the fact
that get_timer() is monotonic. reset_timer() resets the value back to zero.
Best Regards,
Reinhard
next prev parent reply other threads:[~2011-05-20 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 10:51 [U-Boot] AT91: CFI support broken esw at bus-elektronik.de
2011-05-20 11:54 ` Reinhard Meyer [this message]
2011-05-20 13:01 ` Jens Scharsig
2011-05-23 7:19 ` Stefan Roese
2011-05-23 7:44 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD65663.1070802@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox