From: Scott McNutt <smcnutt@psyent.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [Timer]Remove calls to [get, reset]_timer outside arch/
Date: Mon, 23 May 2011 09:12:04 -0400 [thread overview]
Message-ID: <4DDA5D24.2060200@psyent.com> (raw)
In-Reply-To: <4DDA53C0.9090508@gmail.com>
Dear Graeme,
Graeme Russ wrote:
> On 23/05/11 22:19, Scott McNutt wrote:
>> Hi Graeme,
>>
>> Graeme Russ wrote:
>>> There is no need to use get_timer() and reset_timer() and there are build
>> I must have missed something WRT reset_timer() -- my apologies
>> if I'm covering old ground.
>>
>> When the timestamp is incremented using an interrupt that occurs with
>> a period greater than 1 ms, we can get early timeouts. reset_timer()
>> solved the problem. What's the recommended approach for dealing with
>> this without reset_timer() ?
>>
>
> There is an active thread on the timer API right now. Short answer - The
> API is broken - Calling reset_timer() is not the right solution because:
> a) It breaks recursive or nested timing loops
> b) For some arches, udelay() has a side-effect as well
>
> All this needs fixing
Understood. However, removing reset_timer() from cfi_flash.c, will
result in early timeouts for certain boards/archs. Your patch removes
commit 22d6c8faac4e9fa43232b0cf4da427ec14d72ad3 (Thu Apr 1 2010).
I'd rather not break something that has been working for over a year
before I know how to make it work again. Fair enough?
Regards,
--Scott
next prev parent reply other threads:[~2011-05-23 13:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 11:54 [U-Boot] [PATCH] [Timer]Remove calls to [get, reset]_timer outside arch/ Graeme Russ
2011-05-23 12:19 ` Scott McNutt
2011-05-23 12:32 ` Graeme Russ
2011-05-23 13:12 ` Scott McNutt [this message]
[not found] ` <4DDA9CDA.1080401@comcast.net>
[not found] ` <4DDAA77F.7020708@psyent.com>
2011-05-23 20:10 ` Graeme Russ
2011-05-23 20:49 ` J. William Campbell
2011-05-23 21:02 ` Graeme Russ
2011-05-23 21:15 ` J. William Campbell
2011-05-24 5:13 ` Graeme Russ
2011-05-24 15:41 ` J. William Campbell
2011-05-23 21:53 ` Wolfgang Denk
2011-05-23 22:44 ` Graeme Russ
2011-05-24 3:20 ` Mike Frysinger
2011-05-23 12:31 ` Jens Scharsig
2011-05-23 13:22 ` Wolfgang Denk
2011-05-23 14:05 ` [U-Boot] Formal acks and patchwork (was: [PATCH] [Timer]Remove calls to [get, reset]_timer outside arch/) Albert ARIBAUD
2011-05-23 18:44 ` Wolfgang Denk
2011-05-23 19:19 ` [U-Boot] Formal acks and patchwork Albert ARIBAUD
2011-05-23 19:42 ` Wolfgang Denk
2011-05-23 20:15 ` Albert ARIBAUD
2011-05-23 13:34 ` [U-Boot] [PATCH] [Timer]Remove calls to [get, reset]_timer outside arch/ Jens Scharsig
[not found] ` <BANLkTik3W7WJbRuiKsC8m0f8iof7JL-ZMg@mail.gmail.com>
2011-05-23 20:09 ` Graeme Russ
2011-05-24 10:54 ` Graeme Russ
2011-05-24 11:13 ` Graeme Russ
2011-05-25 12:17 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDA5D24.2060200@psyent.com \
--to=smcnutt@psyent.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox