From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Mon, 23 May 2011 21:19:29 +0200 Subject: [U-Boot] Formal acks and patchwork In-Reply-To: <20110523184447.C3A941499BF9@gemini.denx.de> References: <1306151649-25640-1-git-send-email-graeme.russ@gmail.com> <4DDA53B7.7020804@bus-elektronik.de> <20110523132208.13BAA1499BF6@gemini.denx.de> <4DDA69A1.1070009@aribaud.net> <20110523184447.C3A941499BF9@gemini.denx.de> Message-ID: <4DDAB341.20006@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 23/05/2011 20:44, Wolfgang Denk a ?crit : > Dear Albert ARIBAUD, > > In message<4DDA69A1.1070009@aribaud.net> you wrote: >> >>> Note that this is NOT nitpicking: Patchwork will automatically add >>> such correct Acked-by: lines to the patch, so we don't have to track >>> thse manually - this saves a LOT of time to the maintainers. >> >> One question: where is the information presented in patchwork, apart >> from coloring the ack line when displaying the patch discussion thread? >> I cannot find e.g. a summary list of all acks to a given patch. > > PW automatically inserts this into the patch if you click on the > "Download: mbox" link, or is you access the patch through pwclient. > > For example, instead of applying a patch directly from my mailbox I > use this file only to get the hash value for the PW entry, and then > use pwclient to apply it and to update it's state: > > HASH=$(pwparser.py --hash<$PATCH) > if [ -z "$HASH" ] > then > echo "ERROR: $PATCH - no such entry in PatchWork">&2 > exit 1 > fi > > if pwclient apply -h $HASH > then > pwclient update -s 'Accepted' -h $HASH > fi > > This is extremely convenient as it automatically takes care of both > the Acks and the state change. Thanks. Looks like this could be handy for many others. Maybe it should be 'backported' into pwclient itself as a new command. > Best regards, > > Wolfgang Denk Amicalement, -- Albert.