From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Waterman Date: Thu, 26 May 2011 14:33:59 -0400 Subject: [U-Boot] [PATCH] [NAND] Fixes 16bit NAND support with the NDFC In-Reply-To: <20110526111100.18e5e0bf@schlenkerla.am.freescale.net> References: <4DD56FCF.2010306@dawning.com> <20110519195009.AD4121491B0E@gemini.denx.de> <4DD57C56.9050904@dawning.com> <4DDE585E.2090100@dawning.com> <20110526111100.18e5e0bf@schlenkerla.am.freescale.net> Message-ID: <4DDE9D17.1070907@dawning.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Scott, > Looks mostly OK to me -- I was going to consider it for next, rather than > master, as despite "fix" in the name it's really adding new hardware support. Ahh, yeah, that makes sense. I will change "Fixes" to "Adds" for next submission. > You may want to use an #ifdef for bus width in nand_boot.c rather than > spending bytes to check it dynamically. OK. I suppose its unlikely that a NAND chip will swap from 8bit to 16bit (or vice versa) from one compile to another :). > Likewise in the non-SPL driver code, you already have > CONFIG_SYS_NDFC_16BIT, so why check dynamically in ndfc_read_byte()? My thought process was something along the lines of one compiled binary working on potentially multiple similar boards... Though in thinking about it, that seems like a needless requirement. I will change to #ifdefs for smaller code size. That's probably more useful overall. Regards, Alex -- Alex Waterman Computer Engineer Phone: 215-896-4920 Email: awaterman at dawning.com