[U-Boot] What is the difference between /lib and /common

[U-Boot] What is the difference between /lib and /common

[Graeme Russ]

Hi Wolfgang,

A quick question for you - What defines what belongs in /lib versus /common?

I get that cmd* and env* belong in /common (U-Boot specific) and crc, zlib,
gunzip, qsort etc belong in /lib (generic)

But others are a bit grey like malloc in /common and display_options() in /lib

The reason I ask is to know where to put the new timer API - I'm thinking
/lib/time.c with udelay() makes the most sense

Regards,

Graeme

[U-Boot] What is the difference between /lib and /common

[Mike Frysinger]

On Saturday, May 28, 2011 06:51:46 Graeme Russ wrote:
> But others are a bit grey like malloc in /common and display_options() in
> /lib

i would think malloc should live in /lib

> The reason I ask is to know where to put the new timer API - I'm thinking
> /lib/time.c with udelay() makes the most sense

yes
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110528/62d9e6fc/attachment.pgp 

[U-Boot] What is the difference between /lib and /common

[Wolfgang Denk]

Dear Graeme Russ,

In message <4DE0D3C2.50004@gmail.com> you wrote:
> 
> A quick question for you - What defines what belongs in /lib versus /common?

/lib should be stuff that is called from (several, many) other files,
while /common is architecture independent code like the central main
loop, command handlers, etc.

> I get that cmd* and env* belong in /common (U-Boot specific) and crc, zlib,
> gunzip, qsort etc belong in /lib (generic)

Correct.

> But others are a bit grey like malloc in /common and display_options() in /lib

s/grey/wrong/

> The reason I ask is to know where to put the new timer API - I'm thinking
> /lib/time.c with udelay() makes the most sense

Agreed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
God made machine language; all the rest is the work of man.