From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Thu, 02 Jun 2011 08:28:36 +0200
Subject: [U-Boot] [PATCH v2] mx31ads: Use the new relocation scheme
In-Reply-To: <1306957601-27016-1-git-send-email-fabio.estevam@freescale.com>
References: <1306957601-27016-1-git-send-email-fabio.estevam@freescale.com>
Message-ID: <4DE72D94.2090604@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 06/01/2011 09:46 PM, Fabio Estevam wrote:
> This fixes the MX31ADS build by using the new relocation scheme.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> ---

Hi Fabio,

> Changes since v1:
> 
> - Fixed lines over 80 characters.
> 
> Build tested only.
> 
> Do not have the hardware handy to test.

Maybe someone can help on this topic ;-)

> -int dram_init (void) +int dram_init(void) +{ +	/* dram_init must
> store complete ramsize in gd->ram_size */ +	gd->ram_size =
> get_ram_size((volatile void *)CONFIG_SYS_SDRAM_BASE,

I know it is the same, but if you use PHYS_SDRAM_1 instead of
CONFIG_SYS_SDRAM_BASE (as most boards do), the reader understands easier
that the start address and the size are strictly connected.

> --- a/board/freescale/mx31ads/u-boot.lds +++
> b/board/freescale/mx31ads/u-boot.lds @@ -48,23 +48,47 @@ SECTIONS
> 

Can we get rid of this file ? We do not need anymore, and you can also
remove config.mk as well.

Your patch makes u-boot.lds in board directory identical (if I have not
missed something) to arch/arm/cpu/arm1136/u-boot.lds.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================