From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] post, arm, memorytest: add support for arm based boards
Date: Fri, 03 Jun 2011 07:39:41 +0200 [thread overview]
Message-ID: <4DE8739D.2040400@denx.de> (raw)
In-Reply-To: <201106021108.57043.vapier@gentoo.org>
Hello Mike,
Mike Frysinger wrote:
> On Thursday, June 02, 2011 01:53:42 Heiko Schocher wrote:
>> Mike Frysinger wrote:
>>> so add bi_memsize to arm ? it's the only arch that lacks it.
>> Hmm.. I thought of that too, but wouldn;t it be better to use
>> gd->ram_size in post/drivers/memory.c, as this is defined in
>> global_data for all archs?
>
> makes me wonder why we have bd->bi_memsize in the first place.
>
> and how can this possibly work ?
> arch/arm/lib/board.c:
> sprintf ((char *)memsz, "%ldk", (bd->bi_memsize / 1024) - pram);
> -mike
Yep, good question ... maybe, no arm based board has defined
"#if defined(CONFIG_PRAM) || defined(CONFIG_LOGBUFFER)"
?
I can make a fix and change this to gd->ram_size?
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-06-03 5:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 6:24 [U-Boot] [PATCH] post, memorytest: fix if vstart is not = 0x0 Heiko Schocher
2011-06-01 6:24 ` [U-Boot] [PATCH] post, arm, memorytest: add support for arm based boards Heiko Schocher
2011-06-01 6:37 ` Wolfgang Denk
2011-06-01 6:54 ` Heiko Schocher
2011-06-01 13:51 ` Mike Frysinger
2011-06-02 5:53 ` Heiko Schocher
2011-06-02 12:40 ` Wolfgang Denk
2011-06-02 15:08 ` Mike Frysinger
2011-06-03 5:39 ` Heiko Schocher [this message]
2011-06-03 6:30 ` Wolfgang Denk
2011-06-01 6:24 ` [U-Boot] [PATCH] post, memory test: add memory_post_test() to include file Heiko Schocher
2011-07-25 21:43 ` Wolfgang Denk
2011-07-26 8:26 ` Wolfgang Denk
2011-07-26 11:57 ` Wolfgang Denk
2011-07-26 16:41 ` Heiko Schocher
2011-07-27 6:31 ` [U-Boot] [PATCH v2] " Heiko Schocher
2011-07-28 20:39 ` Wolfgang Denk
2011-07-27 21:37 ` [U-Boot] [PATCH] post, memorytest: fix if vstart is not = 0x0 Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE8739D.2040400@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox