From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 03 Jun 2011 07:39:41 +0200 Subject: [U-Boot] [PATCH] post, arm, memorytest: add support for arm based boards In-Reply-To: <201106021108.57043.vapier@gentoo.org> References: <1306909447-19603-1-git-send-email-hs@denx.de> <201106010951.42345.vapier@gentoo.org> <4DE72566.9040008@denx.de> <201106021108.57043.vapier@gentoo.org> Message-ID: <4DE8739D.2040400@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Mike, Mike Frysinger wrote: > On Thursday, June 02, 2011 01:53:42 Heiko Schocher wrote: >> Mike Frysinger wrote: >>> so add bi_memsize to arm ? it's the only arch that lacks it. >> Hmm.. I thought of that too, but wouldn;t it be better to use >> gd->ram_size in post/drivers/memory.c, as this is defined in >> global_data for all archs? > > makes me wonder why we have bd->bi_memsize in the first place. > > and how can this possibly work ? > arch/arm/lib/board.c: > sprintf ((char *)memsz, "%ldk", (bd->bi_memsize / 1024) - pram); > -mike Yep, good question ... maybe, no arm based board has defined "#if defined(CONFIG_PRAM) || defined(CONFIG_LOGBUFFER)" ? I can make a fix and change this to gd->ram_size? bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany