public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Question re: Bluewater Systems Snapper 9260 and 9G20 modules patch
Date: Sat, 04 Jun 2011 22:50:07 +0200	[thread overview]
Message-ID: <4DEA9A7F.4020504@eukrea.com> (raw)
In-Reply-To: <BANLkTi=piA_hj7J_CiS=S_JpuC2P=+_xhA@mail.gmail.com>

Hi Simon,

On 04/06/2011 20:47, Simon Glass wrote:
> Hi Reinhard,
>
> I have been asked to have a quick look at this patch, which is showing
> accepted here:
>
> http://patchwork.ozlabs.org/patch/81422/
>
> The diffstat on patchwork is:
>
>   MAINTAINERS                               |    5 +
>   board/bluewater/snapper9260/Makefile      |   53 ++++++++
>   board/bluewater/snapper9260/snapper9260.c |  169 +++++++++++++++++++++++++
>   boards.cfg                                |    2 +
>   include/configs/snapper9260.h             |  191 +++++++++++++++++++++++++++++
>   5 files changed, 420 insertions(+), 0 deletions(-)
>   create mode 100644 board/bluewater/snapper9260/Makefile
>   create mode 100644 board/bluewater/snapper9260/snapper9260.c
>   create mode 100644 include/configs/snapper9260.h
>
> but when I look at the commit I only see this:
>
> git log --author=Ryan --stat
> commit 74cd9777f8dd44fd944a9ac75cfbc24eeb206453
> Author: Ryan Mallon<ryan@bluewatersys.com>
> Date:   Tue Feb 1 16:18:00 2011 +0000
>
>      Add support for Bluewater Systems Snapper 9260 and 9G20 modules
>
>      Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20
>      single board computer modules. Includes NAND flash and Ethernet
>      support.
>
>      Signed-off-by: Ryan Mallon<ryan@bluewatersys.com>
>
>   boards.cfg |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
>
> As a result it does not build. Has something been dropped by mistake?
>
9260 seems broken (and also arch/arm/cpu/arm926ejs/at91/lowlevel_init.S), this 
may help :

diff --git a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c 
b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
index 6bdc75c..ace1ca8 100644
--- a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
+++ b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
@@ -24,9 +24,10 @@

  #include <common.h>
  #include <asm/io.h>
+#include <asm/arch/hardware.h>
  #include <asm/arch/at91_common.h>
  #include <asm/arch/at91_pmc.h>
-#include <asm/arch/gpio.h>
+#include <asm/arch/at91_pio.h>

  /*
   * if CONFIG_AT91_GPIO_PULLUP ist set, keep pullups on on all

  reply	other threads:[~2011-06-04 20:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-04 18:47 [U-Boot] Question re: Bluewater Systems Snapper 9260 and 9G20 modules patch Simon Glass
2011-06-04 20:50 ` Eric Bénard [this message]
2011-06-05  3:56   ` Simon Glass
2011-06-05  3:59   ` Simon Glass
2011-06-05 12:57 ` Reinhard Meyer
2011-06-05 17:23   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DEA9A7F.4020504@eukrea.com \
    --to=eric@eukrea.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox