* [U-Boot] Question re: Bluewater Systems Snapper 9260 and 9G20 modules patch
@ 2011-06-04 18:47 Simon Glass
2011-06-04 20:50 ` Eric Bénard
2011-06-05 12:57 ` Reinhard Meyer
0 siblings, 2 replies; 6+ messages in thread
From: Simon Glass @ 2011-06-04 18:47 UTC (permalink / raw)
To: u-boot
Hi Reinhard,
I have been asked to have a quick look at this patch, which is showing
accepted here:
http://patchwork.ozlabs.org/patch/81422/
The diffstat on patchwork is:
MAINTAINERS | 5 +
board/bluewater/snapper9260/Makefile | 53 ++++++++
board/bluewater/snapper9260/snapper9260.c | 169 +++++++++++++++++++++++++
boards.cfg | 2 +
include/configs/snapper9260.h | 191 +++++++++++++++++++++++++++++
5 files changed, 420 insertions(+), 0 deletions(-)
create mode 100644 board/bluewater/snapper9260/Makefile
create mode 100644 board/bluewater/snapper9260/snapper9260.c
create mode 100644 include/configs/snapper9260.h
but when I look at the commit I only see this:
git log --author=Ryan --stat
commit 74cd9777f8dd44fd944a9ac75cfbc24eeb206453
Author: Ryan Mallon <ryan@bluewatersys.com>
Date: Tue Feb 1 16:18:00 2011 +0000
Add support for Bluewater Systems Snapper 9260 and 9G20 modules
Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20
single board computer modules. Includes NAND flash and Ethernet
support.
Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
boards.cfg | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
As a result it does not build. Has something been dropped by mistake?
Regards,
Simon
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] Question re: Bluewater Systems Snapper 9260 and 9G20 modules patch
2011-06-04 18:47 [U-Boot] Question re: Bluewater Systems Snapper 9260 and 9G20 modules patch Simon Glass
@ 2011-06-04 20:50 ` Eric Bénard
2011-06-05 3:56 ` Simon Glass
2011-06-05 3:59 ` Simon Glass
2011-06-05 12:57 ` Reinhard Meyer
1 sibling, 2 replies; 6+ messages in thread
From: Eric Bénard @ 2011-06-04 20:50 UTC (permalink / raw)
To: u-boot
Hi Simon,
On 04/06/2011 20:47, Simon Glass wrote:
> Hi Reinhard,
>
> I have been asked to have a quick look at this patch, which is showing
> accepted here:
>
> http://patchwork.ozlabs.org/patch/81422/
>
> The diffstat on patchwork is:
>
> MAINTAINERS | 5 +
> board/bluewater/snapper9260/Makefile | 53 ++++++++
> board/bluewater/snapper9260/snapper9260.c | 169 +++++++++++++++++++++++++
> boards.cfg | 2 +
> include/configs/snapper9260.h | 191 +++++++++++++++++++++++++++++
> 5 files changed, 420 insertions(+), 0 deletions(-)
> create mode 100644 board/bluewater/snapper9260/Makefile
> create mode 100644 board/bluewater/snapper9260/snapper9260.c
> create mode 100644 include/configs/snapper9260.h
>
> but when I look at the commit I only see this:
>
> git log --author=Ryan --stat
> commit 74cd9777f8dd44fd944a9ac75cfbc24eeb206453
> Author: Ryan Mallon<ryan@bluewatersys.com>
> Date: Tue Feb 1 16:18:00 2011 +0000
>
> Add support for Bluewater Systems Snapper 9260 and 9G20 modules
>
> Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20
> single board computer modules. Includes NAND flash and Ethernet
> support.
>
> Signed-off-by: Ryan Mallon<ryan@bluewatersys.com>
>
> boards.cfg | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>
> As a result it does not build. Has something been dropped by mistake?
>
9260 seems broken (and also arch/arm/cpu/arm926ejs/at91/lowlevel_init.S), this
may help :
diff --git a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
index 6bdc75c..ace1ca8 100644
--- a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
+++ b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
@@ -24,9 +24,10 @@
#include <common.h>
#include <asm/io.h>
+#include <asm/arch/hardware.h>
#include <asm/arch/at91_common.h>
#include <asm/arch/at91_pmc.h>
-#include <asm/arch/gpio.h>
+#include <asm/arch/at91_pio.h>
/*
* if CONFIG_AT91_GPIO_PULLUP ist set, keep pullups on on all
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] Question re: Bluewater Systems Snapper 9260 and 9G20 modules patch
2011-06-04 20:50 ` Eric Bénard
@ 2011-06-05 3:56 ` Simon Glass
2011-06-05 3:59 ` Simon Glass
1 sibling, 0 replies; 6+ messages in thread
From: Simon Glass @ 2011-06-05 3:56 UTC (permalink / raw)
To: u-boot
Hi Eric,
Thanks - but the bigger problem is that snapper9260.c isn't even in the
repository!
Regards,
Simon
On Sat, Jun 4, 2011 at 1:50 PM, Eric B?nard <eric@eukrea.com> wrote:
> Hi Simon,
>
> On 04/06/2011 20:47, Simon Glass wrote:
> > Hi Reinhard,
> >
> > I have been asked to have a quick look at this patch, which is showing
> > accepted here:
> >
> > http://patchwork.ozlabs.org/patch/81422/
> >
> > The diffstat on patchwork is:
> >
> > MAINTAINERS | 5 +
> > board/bluewater/snapper9260/Makefile | 53 ++++++++
> > board/bluewater/snapper9260/snapper9260.c | 169
> +++++++++++++++++++++++++
> > boards.cfg | 2 +
> > include/configs/snapper9260.h | 191
> +++++++++++++++++++++++++++++
> > 5 files changed, 420 insertions(+), 0 deletions(-)
> > create mode 100644 board/bluewater/snapper9260/Makefile
> > create mode 100644 board/bluewater/snapper9260/snapper9260.c
> > create mode 100644 include/configs/snapper9260.h
> >
> > but when I look at the commit I only see this:
> >
> > git log --author=Ryan --stat
> > commit 74cd9777f8dd44fd944a9ac75cfbc24eeb206453
> > Author: Ryan Mallon<ryan@bluewatersys.com>
> > Date: Tue Feb 1 16:18:00 2011 +0000
> >
> > Add support for Bluewater Systems Snapper 9260 and 9G20 modules
> >
> > Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20
> > single board computer modules. Includes NAND flash and Ethernet
> > support.
> >
> > Signed-off-by: Ryan Mallon<ryan@bluewatersys.com>
> >
> > boards.cfg | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> >
> > As a result it does not build. Has something been dropped by mistake?
> >
> 9260 seems broken (and also arch/arm/cpu/arm926ejs/at91/lowlevel_init.S),
> this
> may help :
>
> diff --git a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
> b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
> index 6bdc75c..ace1ca8 100644
> --- a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
> +++ b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
> @@ -24,9 +24,10 @@
>
> #include <common.h>
> #include <asm/io.h>
> +#include <asm/arch/hardware.h>
> #include <asm/arch/at91_common.h>
> #include <asm/arch/at91_pmc.h>
> -#include <asm/arch/gpio.h>
> +#include <asm/arch/at91_pio.h>
>
> /*
> * if CONFIG_AT91_GPIO_PULLUP ist set, keep pullups on on all
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
--
* Design A* Simon Glass
sglass at designa-electronics.com
www.designa-electronics.com
5 Amuri Park, 404 Barbadoes St
PO Box 13 889, Christchurch 8013
New Zealand
Phone +64 3 3779127
Fax +64 3 3779135
Freecall:Australia 1800 148 751 USA 1800 261 2934
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] Question re: Bluewater Systems Snapper 9260 and 9G20 modules patch
2011-06-04 20:50 ` Eric Bénard
2011-06-05 3:56 ` Simon Glass
@ 2011-06-05 3:59 ` Simon Glass
1 sibling, 0 replies; 6+ messages in thread
From: Simon Glass @ 2011-06-05 3:59 UTC (permalink / raw)
To: u-boot
On Sat, Jun 4, 2011 at 1:50 PM, Eric B?nard <eric@eukrea.com> wrote:
> Hi Simon,
>
> On 04/06/2011 20:47, Simon Glass wrote:
> > Hi Reinhard,
> >
> > I have been asked to have a quick look at this patch, which is showing
> > accepted here:
> >
> > http://patchwork.ozlabs.org/patch/81422/
> >
> > The diffstat on patchwork is:
> >
> > MAINTAINERS | 5 +
> > board/bluewater/snapper9260/Makefile | 53 ++++++++
> > board/bluewater/snapper9260/snapper9260.c | 169
> +++++++++++++++++++++++++
> > boards.cfg | 2 +
> > include/configs/snapper9260.h | 191
> +++++++++++++++++++++++++++++
> > 5 files changed, 420 insertions(+), 0 deletions(-)
> > create mode 100644 board/bluewater/snapper9260/Makefile
> > create mode 100644 board/bluewater/snapper9260/snapper9260.c
> > create mode 100644 include/configs/snapper9260.h
> >
> > but when I look at the commit I only see this:
> >
> > git log --author=Ryan --stat
> > commit 74cd9777f8dd44fd944a9ac75cfbc24eeb206453
> > Author: Ryan Mallon<ryan@bluewatersys.com>
> > Date: Tue Feb 1 16:18:00 2011 +0000
> >
> > Add support for Bluewater Systems Snapper 9260 and 9G20 modules
> >
> > Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20
> > single board computer modules. Includes NAND flash and Ethernet
> > support.
> >
> > Signed-off-by: Ryan Mallon<ryan@bluewatersys.com>
> >
> > boards.cfg | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> >
> > As a result it does not build. Has something been dropped by mistake?
> >
> 9260 seems broken (and also arch/arm/cpu/arm926ejs/at91/lowlevel_init.S),
> this
> may help :
>
> diff --git a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
> b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
> index 6bdc75c..ace1ca8 100644
> --- a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
> +++ b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c
> @@ -24,9 +24,10 @@
>
> #include <common.h>
> #include <asm/io.h>
> +#include <asm/arch/hardware.h>
> #include <asm/arch/at91_common.h>
> #include <asm/arch/at91_pmc.h>
> -#include <asm/arch/gpio.h>
> +#include <asm/arch/at91_pio.h>
>
> /*
> * if CONFIG_AT91_GPIO_PULLUP ist set, keep pullups on on all
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Hi,
Thanks for that - however it seems that snapper9260.c is missing from the
repository.
Regards,
Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] Question re: Bluewater Systems Snapper 9260 and 9G20 modules patch
2011-06-04 18:47 [U-Boot] Question re: Bluewater Systems Snapper 9260 and 9G20 modules patch Simon Glass
2011-06-04 20:50 ` Eric Bénard
@ 2011-06-05 12:57 ` Reinhard Meyer
2011-06-05 17:23 ` Simon Glass
1 sibling, 1 reply; 6+ messages in thread
From: Reinhard Meyer @ 2011-06-05 12:57 UTC (permalink / raw)
To: u-boot
Dear Simon Glass,
> Hi Reinhard,
>
> I have been asked to have a quick look at this patch, which is showing accepted here:
>
> http://patchwork.ozlabs.org/patch/81422/
>
> The diffstat on patchwork is:
>
> MAINTAINERS | 5 +
> board/bluewater/snapper9260/Makefile | 53 ++++++++
> board/bluewater/snapper9260/snapper9260.c | 169 +++++++++++++++++++++++++
> boards.cfg | 2 +
> include/configs/snapper9260.h | 191 +++++++++++++++++++++++++++++
> 5 files changed, 420 insertions(+), 0 deletions(-)
> create mode 100644 board/bluewater/snapper9260/Makefile
> create mode 100644 board/bluewater/snapper9260/snapper9260.c
> create mode 100644 include/configs/snapper9260.h
>
> but when I look at the commit I only see this:
>
> git log --author=Ryan --stat
> commit 74cd9777f8dd44fd944a9ac75cfbc24eeb206453
> Author: Ryan Mallon <ryan at bluewatersys.com <mailto:ryan@bluewatersys.com>>
> Date: Tue Feb 1 16:18:00 2011 +0000
>
> Add support for Bluewater Systems Snapper 9260 and 9G20 modules
>
> Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20
> single board computer modules. Includes NAND flash and Ethernet
> support.
>
> Signed-off-by: Ryan Mallon <ryan at bluewatersys.com <mailto:ryan@bluewatersys.com>>
>
> boards.cfg | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>
> As a result it does not build. Has something been dropped by mistake?
I had accepted that patch after manually fixing the style problems. I do not know why the
fixed files got lost. The accepted patch was V3. Since then a V4 patch had been posted to
which Albert had commented and I therefore put it on "changes requested".
I would think its now the best way to get a redone V5 patch (based on current TOT)
for those boards ASAP.
Sorry for the mixup.
Best Regards,
Reinhard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] Question re: Bluewater Systems Snapper 9260 and 9G20 modules patch
2011-06-05 12:57 ` Reinhard Meyer
@ 2011-06-05 17:23 ` Simon Glass
0 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2011-06-05 17:23 UTC (permalink / raw)
To: u-boot
On Sun, Jun 5, 2011 at 5:57 AM, Reinhard Meyer <u-boot@emk-elektronik.de>wrote:
> Dear Simon Glass,
> > Hi Reinhard,
> >
> > I have been asked to have a quick look at this patch, which is showing
> accepted here:
> >
> > http://patchwork.ozlabs.org/patch/81422/
> >
>
...
> I had accepted that patch after manually fixing the style problems. I do
> not know why the
> fixed files got lost. The accepted patch was V3. Since then a V4 patch had
> been posted to
> which Albert had commented and I therefore put it on "changes requested".
> I would think its now the best way to get a redone V5 patch (based on
> current TOT)
> for those boards ASAP.
> Sorry for the mixup.
>
> Best Regards,
> Reinhard
>
Hi Reinhard,
Thanks for the clarification - it is no problem. I have done what you have
suggested and resent Ryan's patch as V5. Hopefully this will be OK now.
Regards,
Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-05 17:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-04 18:47 [U-Boot] Question re: Bluewater Systems Snapper 9260 and 9G20 modules patch Simon Glass
2011-06-04 20:50 ` Eric Bénard
2011-06-05 3:56 ` Simon Glass
2011-06-05 3:59 ` Simon Glass
2011-06-05 12:57 ` Reinhard Meyer
2011-06-05 17:23 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox