public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vipin Kumar <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: designware: fix uninitialized phy_addr usage
Date: Mon, 6 Jun 2011 09:51:42 +0530	[thread overview]
Message-ID: <4DEC55D6.7000209@st.com> (raw)
In-Reply-To: <1307027978-13418-2-git-send-email-vapier@gentoo.org>

On 6/2/2011 8:49 PM, Mike Frysinger wrote:
> When CONFIG_DW_SEARCH_PHY is disabled, the local phy_addr variable never
> gets initialized causes random behavior at runtime and a gcc warning.  So
> set it by default to the stored phy address.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  drivers/net/designware.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/designware.c b/drivers/net/designware.c
> index 96f20d1..bfa4384 100644
> --- a/drivers/net/designware.c
> +++ b/drivers/net/designware.c
> @@ -383,6 +383,8 @@ static int configure_phy(struct eth_device *dev)
>  		priv->address = phy_addr;
>  	else
>  		return -1;
> +#else
> +	phy_addr = priv->address;
>  #endif
>  	if (dw_reset_phy(dev) < 0)
>  		return -1;

Reviewed-by: Vipin Kumar <vipin.kumar@st.com>
Thanks Mike

Regards
Vipin

  reply	other threads:[~2011-06-06  4:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 15:19 [U-Boot] [PATCH] net: designware: fix unused warning when CONFIG_DW_AUTONEG is enabled Mike Frysinger
2011-06-02 15:19 ` [U-Boot] [PATCH] net: designware: fix uninitialized phy_addr usage Mike Frysinger
2011-06-06  4:21   ` Vipin Kumar [this message]
2011-07-25 20:21   ` Wolfgang Denk
2011-06-06  4:21 ` [U-Boot] [PATCH] net: designware: fix unused warning when CONFIG_DW_AUTONEG is enabled Vipin Kumar
2011-07-25 20:20 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DEC55D6.7000209@st.com \
    --to=vipin.kumar@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox