From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vipin Kumar Date: Mon, 6 Jun 2011 09:51:42 +0530 Subject: [U-Boot] [PATCH] net: designware: fix uninitialized phy_addr usage In-Reply-To: <1307027978-13418-2-git-send-email-vapier@gentoo.org> References: <1307027978-13418-1-git-send-email-vapier@gentoo.org> <1307027978-13418-2-git-send-email-vapier@gentoo.org> Message-ID: <4DEC55D6.7000209@st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 6/2/2011 8:49 PM, Mike Frysinger wrote: > When CONFIG_DW_SEARCH_PHY is disabled, the local phy_addr variable never > gets initialized causes random behavior at runtime and a gcc warning. So > set it by default to the stored phy address. > > Signed-off-by: Mike Frysinger > --- > drivers/net/designware.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/designware.c b/drivers/net/designware.c > index 96f20d1..bfa4384 100644 > --- a/drivers/net/designware.c > +++ b/drivers/net/designware.c > @@ -383,6 +383,8 @@ static int configure_phy(struct eth_device *dev) > priv->address = phy_addr; > else > return -1; > +#else > + phy_addr = priv->address; > #endif > if (dw_reset_phy(dev) < 0) > return -1; Reviewed-by: Vipin Kumar Thanks Mike Regards Vipin