From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] ATMEL atmel_dataflash_spi.c - work at hand - can someone do it ?
Date: Mon, 06 Jun 2011 11:58:05 +0200 [thread overview]
Message-ID: <4DECA4AD.6020307@emk-elektronik.de> (raw)
Hello,
I am just now quick fixing that driver so it will build with current TOT.
But this driver otherwise still is a bit of a mess:
1. It does not use struct SoC access.
2. It needs to include BOTH drivers/spi/atmel_spi.h
AND arch/arm/include/asm/arch-at91/at91_spi.h !
It would be helpful is someone interested would implement the following
changes:
1. get rid of at91_spi.h (move SoC struct to atmel_spi.h, the LEGACY defines in
that file are also found in atmel_spi.h with an improved name scheme)
2. change driver to use defines from atmel_spi.h (see 1.)
3. change driver to use struct SoC access (that would be perfect!)
It might also be possible to do some factoring of atmel_spi.c and atmel_dataflash_spi.c?
Best Regards,
Reinhard
reply other threads:[~2011-06-06 9:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DECA4AD.6020307@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox