public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] ATMEL atmel_dataflash_spi.c - work at hand - can someone do it ?
@ 2011-06-06  9:58 Reinhard Meyer
  0 siblings, 0 replies; only message in thread
From: Reinhard Meyer @ 2011-06-06  9:58 UTC (permalink / raw)
  To: u-boot

Hello,

I am just now quick fixing that driver so it will build with current TOT.
But this driver otherwise still is a bit of a mess:

1. It does not use struct SoC access.

2. It needs to include BOTH drivers/spi/atmel_spi.h
AND arch/arm/include/asm/arch-at91/at91_spi.h !

It would be helpful is someone interested would implement the following
changes:

1. get rid of at91_spi.h (move SoC struct to atmel_spi.h, the LEGACY defines in
that file are also found in atmel_spi.h with an improved name scheme)
2. change driver to use defines from atmel_spi.h (see 1.)
3. change driver to use struct SoC access (that would be perfect!)

It might also be possible to do some factoring of atmel_spi.c and atmel_dataflash_spi.c?

Best Regards,

Reinhard

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-06-06  9:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-06  9:58 [U-Boot] ATMEL atmel_dataflash_spi.c - work at hand - can someone do it ? Reinhard Meyer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox