public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] arm926ejs/at91/lowlevel_init.S: temporary fix
Date: Tue, 07 Jun 2011 10:04:27 +0200	[thread overview]
Message-ID: <4DEDDB8B.1050900@emk-elektronik.de> (raw)
In-Reply-To: <1307428508-26058-3-git-send-email-eric@eukrea.com>

Dear Eric B?nard,
> handle the case where AT91_SDRAM_BASE and AT91_PIO_BASE are not
> defined
> 
> Signed-off-by: Eric B?nard <eric@eukrea.com>
> ---
>  arch/arm/cpu/arm926ejs/at91/lowlevel_init.S |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/at91/lowlevel_init.S b/arch/arm/cpu/arm926ejs/at91/lowlevel_init.S
> index 7f7ca5e..7cbbb54 100644
> --- a/arch/arm/cpu/arm926ejs/at91/lowlevel_init.S
> +++ b/arch/arm/cpu/arm926ejs/at91/lowlevel_init.S
> @@ -42,6 +42,14 @@
>  #define CONFIG_SYS_MATRIX_EBICSA_VAL CONFIG_SYS_MATRIX_EBI0CSA_VAL
>  #endif
>  
> +#ifndef AT91_SDRAM_BASE
> +#define AT91_SDRAM_BASE		ATMEL_BASE_CS1
> +#endif
> +
> +#ifndef AT91_PIO_BASE
> +#define AT91_PIO_BASE		ATMEL_BASE_PIOA
> +#endif
> +
>  _TEXT_BASE:
>  	.word	CONFIG_SYS_TEXT_BASE
>  
How "temporary" is "temporary"?

This fix could be done better, by using
CONFIG_SYS_SDRAM_BASE right away, and using ATMEL_BASE_PIOA
as well in that file.

Please resubmit this fix, or explain why it cannot be done the
way I suggested.

Best Regards,

Reinhard

  reply	other threads:[~2011-06-07  8:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07  6:35 [U-Boot] [PATCH 1/5] at91sam9260_devices: fix following atmal rework Eric Bénard
2011-06-07  6:35 ` [U-Boot] [PATCH 2/5] include/asm/arch-at91: update several .h files to ATMEL_xxx name scheme Eric Bénard
2011-06-07  6:35 ` [U-Boot] [PATCH 3/5] arm926ejs/at91/lowlevel_init.S: temporary fix Eric Bénard
2011-06-07  8:04   ` Reinhard Meyer [this message]
2011-06-07  8:32     ` Eric Bénard
2011-06-07  6:35 ` [U-Boot] [PATCH 4/5] cpu9260/9G20: fix board support Eric Bénard
2011-06-07  6:35 ` [U-Boot] [PATCH 5/5] cpuat91: " Eric Bénard
2011-06-07  7:56 ` [U-Boot] [PATCH 1/5] at91sam9260_devices: fix following atmal rework Reinhard Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DEDDB8B.1050900@emk-elektronik.de \
    --to=u-boot@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox