From: "Eric Bénard" <eric@eukrea.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] arm926ejs/at91/lowlevel_init.S: temporary fix
Date: Tue, 07 Jun 2011 10:32:25 +0200 [thread overview]
Message-ID: <4DEDE219.50301@eukrea.com> (raw)
In-Reply-To: <4DEDDB8B.1050900@emk-elektronik.de>
Hi Reinhard,
On 07/06/2011 10:04, Reinhard Meyer wrote:
> How "temporary" is "temporary"?
>
> This fix could be done better, by using
> CONFIG_SYS_SDRAM_BASE right away, and using ATMEL_BASE_PIOA
> as well in that file.
>
> Please resubmit this fix, or explain why it cannot be done the
> way I suggested.
>
may I suggest that the next time you rename some defines, you also fix all the
places where these defines were used instead of pushing comits which break
several parts of u-boot ?
Eric
next prev parent reply other threads:[~2011-06-07 8:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 6:35 [U-Boot] [PATCH 1/5] at91sam9260_devices: fix following atmal rework Eric Bénard
2011-06-07 6:35 ` [U-Boot] [PATCH 2/5] include/asm/arch-at91: update several .h files to ATMEL_xxx name scheme Eric Bénard
2011-06-07 6:35 ` [U-Boot] [PATCH 3/5] arm926ejs/at91/lowlevel_init.S: temporary fix Eric Bénard
2011-06-07 8:04 ` Reinhard Meyer
2011-06-07 8:32 ` Eric Bénard [this message]
2011-06-07 6:35 ` [U-Boot] [PATCH 4/5] cpu9260/9G20: fix board support Eric Bénard
2011-06-07 6:35 ` [U-Boot] [PATCH 5/5] cpuat91: " Eric Bénard
2011-06-07 7:56 ` [U-Boot] [PATCH 1/5] at91sam9260_devices: fix following atmal rework Reinhard Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEDE219.50301@eukrea.com \
--to=eric@eukrea.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox