From: Alex Waterman <awaterman@dawning.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] NAND: Add 16bit NAND support for the NDFC
Date: Tue, 07 Jun 2011 08:33:25 -0400 [thread overview]
Message-ID: <4DEE1A95.1040801@dawning.com> (raw)
In-Reply-To: <20110606203810.GA25519@schlenkerla.am.freescale.net>
>> +#ifdef CONFIG_SYS_NDFC_16BIT
>> /* Shift the offset from byte addressing to word addressing. */
>> - if (this->options & NAND_BUSWIDTH_16)
>> - offs >>= 1;
>> + offs >>= 1;
>> +#endif
>
> This is not an NDFC-specific file.
Oh, yeah, I see. This should not have been swapped to a preprocessor
condition. Could we make a general define for 16 bit NAND not just limited
to the NDFC? Or would you rather just have the extra if condition despite
the extra code space it takes up?
Regards,
Alex
--
Alex Waterman
Computer Engineer
Phone: 215-896-4920
Email: awaterman at dawning.com
next prev parent reply other threads:[~2011-06-07 12:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 14:00 [U-Boot] [PATCH v2] NAND: Add 16bit NAND support for the NDFC Alex Waterman
2011-06-06 20:38 ` Scott Wood
2011-06-07 12:33 ` Alex Waterman [this message]
2011-06-07 16:32 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEE1A95.1040801@dawning.com \
--to=awaterman@dawning.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox