From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Waterman <awaterman@dawning.com>
Date: Tue, 07 Jun 2011 08:33:25 -0400
Subject: [U-Boot] [PATCH v2] NAND: Add 16bit NAND support for the NDFC
In-Reply-To: <20110606203810.GA25519@schlenkerla.am.freescale.net>
References: <4DDFAE67.10208@dawning.com>
	<20110606203810.GA25519@schlenkerla.am.freescale.net>
Message-ID: <4DEE1A95.1040801@dawning.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


>> +#ifdef CONFIG_SYS_NDFC_16BIT
>>  	/* Shift the offset from byte addressing to word addressing. */
>> -	if (this->options & NAND_BUSWIDTH_16)
>> -		offs >>= 1;
>> +	offs >>= 1;
>> +#endif
> 
> This is not an NDFC-specific file.

Oh, yeah, I see. This should not have been swapped to a preprocessor
condition. Could we make a general define for 16 bit NAND not just limited
to the NDFC? Or would you rather just have the extra if condition despite
the extra code space it takes up?

Regards,
Alex

-- 
Alex Waterman
Computer Engineer
Phone: 215-896-4920
Email: awaterman at dawning.com