From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 1/4] MX5: Make the weim structure complete
Date: Tue, 07 Jun 2011 15:31:13 +0200 [thread overview]
Message-ID: <4DEE2821.9070607@denx.de> (raw)
In-Reply-To: <BANLkTin_6dypOyhZW6uw-=jyvScoDVb9Hg@mail.gmail.com>
On 05/27/2011 02:40 PM, Fabio Estevam wrote:
> Hi Stefano,
>
> Does this patch series look fine now?
>
Hi Fabio,
I see some warnings that must be dropped before putting your patches
into the mainline:
Configuring for mx53ard - Board: mx53ard, Options:
IMX_CONFIG=board/freescale/mx53ard/imximage_dd3.cfg
soc.c: In function 'set_chipselect_size':
soc.c:169: warning: initialization from incompatible pointer type
In fact:
struct iomuxc *iomuxc_regs = (struct weim *)IOMUXC_BASE_ADDR;
^-- this should be struct iomuxc
mx53ard.c:176: warning: function declaration isn't a prototype
mx53ard.c:259: warning: function declaration isn't a prototype
due to static void weim_smc911x_iomux() instead of static void
weim_smc911x_iomux(void).
Can you fix them ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2011-06-07 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 16:14 [U-Boot] [PATCH v5 1/4] MX5: Make the weim structure complete Fabio Estevam
2011-05-23 16:14 ` [U-Boot] [PATCH v5 2/4] MX5: Add iomux structure Fabio Estevam
2011-05-23 16:14 ` [U-Boot] [PATCH v5 3/4] MX5: Introduce a function for setting the chip select size Fabio Estevam
2011-05-23 16:14 ` [U-Boot] [PATCH v5 4/4] MX53: Add initial support for MX53ARD Fabio Estevam
[not found] ` <BANLkTin_6dypOyhZW6uw-=jyvScoDVb9Hg@mail.gmail.com>
2011-05-27 13:04 ` [U-Boot] [PATCH v5 1/4] MX5: Make the weim structure complete Stefano Babic
2011-06-07 13:31 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEE2821.9070607@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox