From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 07 Jun 2011 15:31:13 +0200 Subject: [U-Boot] [PATCH v5 1/4] MX5: Make the weim structure complete In-Reply-To: References: <1306167296-7264-1-git-send-email-fabio.estevam@freescale.com> Message-ID: <4DEE2821.9070607@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/27/2011 02:40 PM, Fabio Estevam wrote: > Hi Stefano, > > Does this patch series look fine now? > Hi Fabio, I see some warnings that must be dropped before putting your patches into the mainline: Configuring for mx53ard - Board: mx53ard, Options: IMX_CONFIG=board/freescale/mx53ard/imximage_dd3.cfg soc.c: In function 'set_chipselect_size': soc.c:169: warning: initialization from incompatible pointer type In fact: struct iomuxc *iomuxc_regs = (struct weim *)IOMUXC_BASE_ADDR; ^-- this should be struct iomuxc mx53ard.c:176: warning: function declaration isn't a prototype mx53ard.c:259: warning: function declaration isn't a prototype due to static void weim_smc911x_iomux() instead of static void weim_smc911x_iomux(void). Can you fix them ? Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================