From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 07 Jun 2011 20:21:08 +0200 Subject: [U-Boot] [STATUS] WARNING: huge ARM board removal pending In-Reply-To: <4DEDBA40.7010303@compulab.co.il> References: <20110602215100.93FDECFB8FE@gemini.denx.de> <4DE8DD3D.2080508@compulab.co.il> <4DED35BC.2010708@aribaud.net> <4DEDBA40.7010303@compulab.co.il> Message-ID: <4DEE6C14.3080509@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Igor, Le 07/06/2011 07:42, Igor Grinberg a ?crit : > On 06/06/11 23:17, Albert ARIBAUD wrote: > >> Hi, >> >> Le 03/06/2011 15:10, Igor Grinberg a ?crit : >>> On 06/03/11 00:51, Wolfgang Denk wrote: >>> >>>> Hi, >>> >>> Hi Wolfgang, >>> >>> [...] >>> >>>> omap1610h2 >>>> omap1610inn >>> >>>> Please submit fixes to prevent removal. >>> >>> I've sent a compile fix [1] for omap1610h2 and omap1610inn about a month ago, >>> but still it hasn't been picked up. >>> >>> Sandeep said, he is on vacation, may be Albert should pick this up instead? >>> >>> [1] http://patchwork.ozlabs.org/patch/93545/ >> >> What exactly do the FIXMEs mean? Are the definitions of CONFIG_SYS_INIT_SP_ADDR somehow incorrect in this patch, or just non-optimal? > > This means, that I could not test those, because I don't have the hardware. > I've taken those from the same SoC, so they should be fine, but again could not test, > so I've added a comment. FIXME implies the writer know something was wrong and mention it. Here, it is less of a FIXME and more of a TODO: test ; and I don't want readers to think there is a known error where there is not. Can you resubmit with the FIXMEs turned into TODOs? Amicalement, -- Albert.