public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [STATUS] WARNING: huge ARM board removal pending
Date: Wed, 08 Jun 2011 23:00:53 +0300	[thread overview]
Message-ID: <4DEFD4F5.4060001@compulab.co.il> (raw)
In-Reply-To: <4DEE6C14.3080509@aribaud.net>

Hi Albert,

On 06/07/11 21:21, Albert ARIBAUD wrote:
> Hi Igor,
>
> Le 07/06/2011 07:42, Igor Grinberg a ?crit :
>> On 06/06/11 23:17, Albert ARIBAUD wrote:
>>
>>> Hi,
>>>
>>> Le 03/06/2011 15:10, Igor Grinberg a ?crit :
>>>> On 06/03/11 00:51, Wolfgang Denk wrote:
>>>>
>>>>> Hi,
>>>>
>>>> Hi Wolfgang,
>>>>
>>>> [...]
>>>>
>>>>> omap1610h2
>>>>> omap1610inn
>>>>
>>>>> Please submit fixes to prevent removal.
>>>>
>>>> I've sent a compile fix [1] for omap1610h2 and omap1610inn about a month ago,
>>>> but still it hasn't been picked up.
>>>>
>>>> Sandeep said, he is on vacation, may be Albert should pick this up instead?
>>>>
>>>> [1] http://patchwork.ozlabs.org/patch/93545/
>>>
>>> What exactly do the FIXMEs mean? Are the definitions of CONFIG_SYS_INIT_SP_ADDR somehow incorrect in this patch, or just non-optimal?
>>
>> This means, that I could not test those, because I don't have the hardware.
>> I've taken those from the same SoC, so they should be fine, but again could not test,
>> so I've added a comment.
>
> FIXME implies the writer know something was wrong and mention it. Here, it is less of a FIXME and more of a TODO: test <whatever>; and I don't want readers to think there is a known error where there is not. Can you resubmit with the FIXMEs turned into TODOs?

I can see Aneesh has posted several fixes of that kind (also for these two boards),
so may be his values are better justified and don't need either TODO or FIXME.
If it is so, then my patch can be dropped.


-- 
Regards,
Igor.

  reply	other threads:[~2011-06-08 20:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 21:51 [U-Boot] [STATUS] WARNING: huge ARM board removal pending Wolfgang Denk
     [not found] ` <8A423D2D-B4CA-422A-813D-E808A0B849A0@googlemail.com>
2011-06-03  8:09   ` Wolfgang Denk
2011-06-03  8:31 ` Andy Pont
2011-06-03 11:13   ` Wolfgang Denk
2011-06-03 11:09 ` Graeme Russ
2011-06-03 12:50 ` Eric Bénard
2011-06-03 13:10 ` Igor Grinberg
2011-06-06 20:17   ` Albert ARIBAUD
2011-06-07  5:42     ` Igor Grinberg
2011-06-07 18:21       ` Albert ARIBAUD
2011-06-08 20:00         ` Igor Grinberg [this message]
2011-06-08 20:23           ` Albert ARIBAUD
2011-06-08  8:47 ` Minkyu Kang
2011-06-08 20:16   ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DEFD4F5.4060001@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox