From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBCaWXDn21hbm4=?= Date: Thu, 09 Jun 2011 11:49:47 +0200 Subject: [U-Boot] [PATCH v2] arm920t/at91: use new clock features from libat91-common In-Reply-To: <4DF09096.2010201@emk-elektronik.de> References: <4DEFAC1D.4030401@scharsoft.de> <1307563560-13358-1-git-send-email-andreas.devel@googlemail.com> <4DF09096.2010201@emk-elektronik.de> Message-ID: <4DF0973B.9010102@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de resent to right list ... Dear Reinhard Meyer, Am 09.06.2011 11:21, schrieb Reinhard Meyer: > Dear Andreas Bie?mann, >> This patch enables the new clock features from new libat91-common. This >> is a required step to get at91rm9200_usart replaced by atmel_usart >> driver. >> >> Signed-off-by: Andreas Bie?mann >> >> Cc: Jens Scharsig >> Cc: Eric B?nard > > I think this should go into NEXT unleass it unbreaks that board right now. > You mentioned in another mail that it would be ok to be in 2011.09. > Is that OK? I'm fine with that. The arm920t/at91 boards do build (with minor warnings in at91_emac and at91rm9200_usart) and work on real hardware since 9e8df9c4db7835152996c96cc432dc6dd70bb17c The warnings are: - 'at91_emac.c:487:2: warning: dereferencing type-punned pointer will break strict-aliasing rules' in at91_emac -> you know about that ... it is the same as in macb driver and will also be fixed soon. - 'at91rm9200_usart.c:39:2: warning: #warning Please update to use C structur SoC access !' -> at91rm9200_usart will be removed soon Therefore I do not see any reason to remove those arm920t/at91 boards. I will do some more testing with atmel_usart driver on atrm9200 devices and send for review this weekend. The big removal of old-style at91rm9200 boards can begin after that cause the deprecated at91rm9200_usart driver needs some outdated stuff which will also be removed in that step. Besides that, I found out cpu.c (in that commit) is missing a GPL header and copyright notice. So please do not add this version. regards Andreas Bie?mann