[U-Boot] [PATCH] MX3: make additional hardware and clocks available

[Stefano Babic <sbabic@denx.de>]

On 06/09/2011 10:58 AM, Helmut Raiger wrote:
> This patch is in preparation for the contribution of our board support. 
> More to follow ...

Hi Helmut,

please replace this with a useful comment for the commit, describing
what the patch is thought to do or which issue should solve.

You must add your Signed-off-by line to your patch. Your patch seems
corrupt and cannot be apply without errors. Think about using git
send-email to post patches, as this avoid mail corruption generated by
mailer.

Please submit your patches together in a single patchset, including
support for your board. This makes everything more readable and easier
to understand why you need some changes.

You should run checkpatch before submitting patches and fix for errors
the tool reports:

ERROR: trailing whitespace
#40: FILE: arch/arm/cpu/arm1136/mx31/devices.c:54:
+ * at board level (physical pin SS0 of CSPI2 may aswell be used as SS0 $

ERROR: patch seems to be corrupt (line wrapped?)
#41: FILE: arch/arm/cpu/arm1136/mx31/devices.c:54:
of CSPI3)

ERROR: Missing Signed-off-by: line(s)

total: 3 errors, 0 warnings, 124 lines checked


> +
>   #ifdef CONFIG_MXC_SPI
> +/* note: putting several spi setups here makes no sense as they may differ
> + * at board level (physical pin SS0 of CSPI2 may aswell be used as SS0 
> of CSPI3)
> + */
>   void mx31_spi2_hw_init(void)
>   {
>       /* SPI2 */
> diff --git a/arch/arm/cpu/arm1136/mx31/generic.c 
> b/arch/arm/cpu/arm1136/mx31/generic.c
> index 4ebf38d..92dd8d6 100644
> --- a/arch/arm/cpu/arm1136/mx31/generic.c
> +++ b/arch/arm/cpu/arm1136/mx31/generic.c
> @@ -71,6 +71,18 @@ u32 mx31_get_ipg_clk(void)
>       return freq;
>   }
> 
> +/* hsp is the clock for the ipu */
> +u32 mx31_get_hsp_clk(void)
> +{
> +      u32 freq = mx31_get_mcu_main_clk();
> +      u32 pdr0 = __REG(CCM_PDR0);
> +
> +      /* divided by HSP_PODF in PDR0 */
> +      freq /= ((pdr0 >> 11) & 0x7) + 1;
> +
> +      return freq;
> +}

Use the same interface implemented on other i.MX processors (MX5, MX35)
to ask for clocks. If you need to get a clock, you should implement
mxc_get_clock().
If you need to get the ipu clock, does it mean you plan to change the
IPU driver, too ?


> diff --git a/arch/arm/include/asm/arch-mx31/imx-regs.h 
> b/arch/arm/include/asm/arch-mx31/imx-regs.h
> old mode 100644
> new mode 100755
> index 306f966..af163cd
> --- a/arch/arm/include/asm/arch-mx31/imx-regs.h
> +++ b/arch/arm/include/asm/arch-mx31/imx-regs.h
> @@ -604,12 +604,41 @@ enum iomux_pins {
> 
>   /* Register offsets based on IOMUXC_BASE */
>   /* 0x00 .. 0x7b */
> +#define MUX_CTL_CSPI3_MISO        0x0c
> +#define MUX_CTL_CSPI3_SCLK        0x0d
> +#define MUX_CTL_CSPI3_SPI_RDY    0x0e
> +#define MUX_CTL_TTM_PAD            0x0f
> +#define MUX_CTL_ATA_RESET_B        0x10
> +#define MUX_CTL_CE_CONTROL        0x11
> +#define MUX_CTL_CLKSS            0x12
> +#define MUX_CTL_CSPI3_MOSI        0x13
> +
> +#define MUX_CTL_SD1_DATA1    0x18
> +#define MUX_CTL_SD1_DATA2    0x19
> +#define MUX_CTL_SD1_DATA3    0x1a
> +#define MUX_CTL_SD1_CMD        0x1d
> +#define MUX_CTL_SD1_CLK        0x1e
> +#define MUX_CTL_SD1_DATA0    0x1f

It seems to me you define a lot of this stuff, but you use only a few of
them.


> diff --git a/include/fsl_pmic.h b/include/fsl_pmic.h
> old mode 100644
> new mode 100755
> index e3abde6..e0ef810
> --- a/include/fsl_pmic.h
> +++ b/include/fsl_pmic.h
> @@ -121,6 +121,8 @@ enum {
>   /* Interrupt status 1 */
>   #define RTCRSTI        (1 << 7)
> 
> +struct spi_slave *pmic_spi_probe(void);
> +void pmic_spi_free(struct spi_slave *slave);

The two functions are used internally to fsl_pmic. At least
pmic_spi_probe is automatically called by the read/write helper if the
spi slave is not set. Why do you need to export them ?

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================