From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] at91_emac: fix compile warning
Date: Thu, 09 Jun 2011 14:06:51 +0200 [thread overview]
Message-ID: <4DF0B75B.4020400@emk-elektronik.de> (raw)
In-Reply-To: <4DF0ADE7.2080906@gmail.com>
Dear Andreas Bie?mann,
>>> + writel( (netdev->enetaddr[0] | netdev->enetaddr[1] << 8 |
>>> + netdev->enetaddr[2] << 16 | netdev->enetaddr[3] << 24),
>>> + &emac->sa2l);
>>
>> OUCH, I would think by precedence rules, | comes before << !?!?!
>
> You are wrong, try the following:
Yep, just checked the table ;) -
+ comes before <<, but << comes before |, hence the mixup :)
>> Already applied to u-boot-atmel/master,
>
> But why do you apply the patch, if there are questions?
At first, the << | seemed ok to me, so I applied ;)
Regards,
Reinhard
next prev parent reply other threads:[~2011-06-09 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 10:22 [U-Boot] [PATCH] at91_emac: fix compile warning Andreas Bießmann
2011-06-09 11:08 ` Reinhard Meyer
2011-06-09 11:26 ` Andreas Bießmann
2011-06-09 12:06 ` Reinhard Meyer [this message]
2011-06-09 12:13 ` Andreas Bießmann
2011-06-12 10:08 ` Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF0B75B.4020400@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox