From mboxrd@z Thu Jan 1 00:00:00 1970 From: Reinhard Meyer Date: Thu, 09 Jun 2011 14:06:51 +0200 Subject: [U-Boot] [PATCH] at91_emac: fix compile warning In-Reply-To: <4DF0ADE7.2080906@gmail.com> References: <1307614974-15516-1-git-send-email-andreas.devel@gmail.com> <4DF0A9B2.5050806@emk-elektronik.de> <4DF0ADE7.2080906@gmail.com> Message-ID: <4DF0B75B.4020400@emk-elektronik.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Andreas Bie?mann, >>> + writel( (netdev->enetaddr[0] | netdev->enetaddr[1] << 8 | >>> + netdev->enetaddr[2] << 16 | netdev->enetaddr[3] << 24), >>> + &emac->sa2l); >> >> OUCH, I would think by precedence rules, | comes before << !?!?! > > You are wrong, try the following: Yep, just checked the table ;) - + comes before <<, but << comes before |, hence the mixup :) >> Already applied to u-boot-atmel/master, > > But why do you apply the patch, if there are questions? At first, the << | seemed ok to me, so I applied ;) Regards, Reinhard