public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Torsten Koschorrek <koschorrek@synertronixx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] scb9328: Add ARM relocation support
Date: Fri, 10 Jun 2011 19:55:46 +0200	[thread overview]
Message-ID: <4DF25AA2.3090701@synertronixx.de> (raw)
In-Reply-To: <4DF1C6BD.9080800@denx.de>

Hello,

Stefano Babic wrote:
> On 06/10/2011 07:44 AM, Torsten Koschorrek wrote:
> Hi Torsten,
>
> send your answer to the ML, too. Someone else can help you ;-)
>

Oh, yes, right. This little 'Reply All' Button, sorry :-)

>>> size1 = get_ram_size((volatile void *)SCB9328_SDRAM_1,
>>>      SCB9328_SDRAM_1_SIZE);
>>> #if ( CONFIG_NR_DRAM_BANKS>   1 )
>>> size2 = get_ram_size((volatile void *)SCB9328_SDRAM_2,
>>>      SCB9328_SDRAM_2_SIZE);
>>> .....
>>>
>>> and then:
>>>      gd->ram_size = size1 + size2 + size3 + size4;
>>>
>>
>> Yes, I thought about it. The thing is, we only have one bank on the
>> system. So, dram_init_banksize() needs a cleanup, but that's a problem
>> for another cleanup-patch, which will be committed in a next step.
>>
>> (If it's needed I could do a minor cleanup first...)
>
> You decide. However, the code in the patch is wrong. If you have only
> one bank, you could directly simplify your code, I think.
>

Good point.

>>
>> Unfortunately I have to work on another project today and next week and
>> I think I'm not able to solve the hanging problem.
>
> Understood, I tried only to give you some hints where to check ;-)
>

... and I appreciate that very much :-) Above all, your answers showed 
me, that I was looking in the right direction so far.

>> Minor fixes (such as
>> config.mk) for the above patch should be possible, though.
>
> Ok, agree. Fix first the problem to make MAKEALL happy and build the
> board again.
>

OK, I just tested it again, MAKEALL is happy.

'include/configs/scb9328.h' is the only file that has to be patched with 
the patch already send to the ml. 'board/scb9328/config.mk' and 
'board/scb9328/scb9328.c' definately need a cleanup, but compilation is 
ok. The cleanup of those two files 'll be done next week. And hopefully 
I find some time next week to work on the hangup problem, too.

> Best regards,
> Stefano Babic
>

Thanks
Torsten

  reply	other threads:[~2011-06-10 17:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-09 11:36 [U-Boot] [PATCH] scb9328: Add ARM relocation support Torsten Koschorrek
2011-06-09 14:34 ` Stefano Babic
     [not found]   ` <4DF1AF2B.6030602@synertronixx.de>
2011-06-10  7:24     ` Stefano Babic
2011-06-10 17:55       ` Torsten Koschorrek [this message]
2011-07-04  9:34         ` Torsten Koschorrek
2011-07-04  9:43           ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF25AA2.3090701@synertronixx.de \
    --to=koschorrek@synertronixx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox