From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/5] arm/km: replace suenx targets with km_kirkwood
Date: Tue, 14 Jun 2011 08:29:41 +0200 [thread overview]
Message-ID: <4DF6FFD5.8050301@keymile.com> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19FAE664E2@SC-VEXCH4.marvell.com>
Hi Prafulla,
On 06/13/2011 10:58 AM, Prafulla Wadaskar wrote:
>>
>> So we should add this include and remove some of the defines which are
>> part of arch-kirkwood/config.h
>> from our km_arm.h. But at one point we have to change arch-
>> kirkwood/config.h. There is:
>>
>> #ifdef CONFIG_CMD_I2C
>> #ifndef CONFIG_SOFT_I2C
>> #define CONFIG_I2C_MVTWSI
>> #define CONFIG_SYS_I2C_SLAVE 0x0
>>
>> This wouldn't work for us because we have CONFIG_CMD_I2C enabled but we
>> use SOFT_I2C and not HARD_I2C
>>
>> I think it is correct if we change it to:
>> #ifdef CONFIG_CMD_I2C
>> +#ifndef CONFIG_SOFT_I2C
>> #define CONFIG_I2C_MVTWSI
>> +#endif
>> #define CONFIG_SYS_I2C_SLAVE 0x0
>>
>> Prafulla if you don't object to this change I would send a patch on
>> tuesday when I'm back at work to
>> change this and to fix the build error.
>
> Hi Holger
> Ack, Pls send the patch for the same. Also send a patch to resolve build error. May be those could be two standalone patches.
>
yes I prepare two patches. I fix this on top of current u-boot master and rebase
the patch serie on top of it. Maybe you want to send this fixes upstream for
inclusion in v2011.06...
Best regards
Holger
next prev parent reply other threads:[~2011-06-14 6:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-11 4:50 [U-Boot] [PATCH v2 4/5] arm/km: replace suenx targets with km_kirkwood Prafulla Wadaskar
2011-06-12 12:09 ` Longchamp, Valentin
2011-06-12 12:40 ` Simon Guinot
2011-06-12 16:11 ` Prafulla Wadaskar
2011-06-12 18:31 ` Holger Brunck
2011-06-13 8:58 ` Prafulla Wadaskar
2011-06-14 6:29 ` Holger Brunck [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-06-08 11:42 [U-Boot] [PATCH v2 0/5] updates for km ARM boards and board support for portl2 Holger Brunck
2011-06-08 11:42 ` [U-Boot] [PATCH v2 4/5] arm/km: replace suenx targets with km_kirkwood Holger Brunck
2011-06-11 4:22 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF6FFD5.8050301@keymile.com \
--to=holger.brunck@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox